You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/18 18:46:44 UTC
[GitHub] merlimat opened a new pull request #1084: Enforce the validation of Pulsar configuration
merlimat opened a new pull request #1084: Enforce the validation of Pulsar configuration
URL: https://github.com/apache/incubator-pulsar/pull/1084
### Motivation
Fix a couple of issues with the validation of the broker config:
1. When reading the config from a properties file, empty fields which are marked as `@Required` should trigger the `IllegalArgumentException`. Currently we're checking for the field to be null, but in fact it's an empty string
2. Validation of the `ServiceConfiguration` is only performed when loading from a file, but not when passing an object to `PulsarService`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services