You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2018/06/06 15:42:04 UTC

[GitHub] nifi pull request #2766: NIFI-3217: Preventing editor close on window resize

GitHub user mcgilman opened a pull request:

    https://github.com/apache/nifi/pull/2766

    NIFI-3217: Preventing editor close on window resize

    NIFI-3217: 
    - Disabling the resize of SlickGrid when there is an active edit occuring. This will prevent the accidental closure of the current edit.
    - Triggering a resize when the active editor closes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mcgilman/nifi NIFI-3217

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2766.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2766
    
----
commit c4d4fc6a70799a902bea1b5c487eeff3d9df21a7
Author: Matt Gilman <ma...@...>
Date:   2018-06-06T15:40:07Z

    NIFI-3217:
    - Disabling the resize of SlickGrid when there is an active edit occuring. This will prevent the accidental closure of the current edit.
    - Triggering a resize when the active editor closes.

----


---

[GitHub] nifi issue #2766: NIFI-3217: Preventing editor close on window resize

Posted by mcgilman <gi...@git.apache.org>.

Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/2766
  
    thanks @scottyaslan for the review!


---

[GitHub] nifi issue #2766: NIFI-3217: Preventing editor close on window resize

Posted by scottyaslan <gi...@git.apache.org>.

Github user scottyaslan commented on the issue:

    https://github.com/apache/nifi/pull/2766
  
    Reviewing...


---

[GitHub] nifi pull request #2766: NIFI-3217: Preventing editor close on window resize

Posted by mcgilman <gi...@git.apache.org>.

Github user mcgilman closed the pull request at:

    https://github.com/apache/nifi/pull/2766


---

[GitHub] nifi issue #2766: NIFI-3217: Preventing editor close on window resize

Posted by scottyaslan <gi...@git.apache.org>.

Github user scottyaslan commented on the issue:

    https://github.com/apache/nifi/pull/2766
  
    @mcgilman I merged this PR to master...thanks for the awesome contrib!


---