You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/03/10 02:06:36 UTC
[GitHub] [kylin] xiacongling opened a new pull request #1605: skip update metrics for queries that hit no realization
xiacongling opened a new pull request #1605:
URL: https://github.com/apache/kylin/pull/1605
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN-4929), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] xiacongling commented on a change in pull request #1605: KYLIN-4929 skip update metrics for queries that hit no realization
Posted by GitBox <gi...@apache.org>.
xiacongling commented on a change in pull request #1605:
URL: https://github.com/apache/kylin/pull/1605#discussion_r591989356
##########
File path: server-base/src/main/java/org/apache/kylin/rest/metrics/QueryMetricsFacade.java
##########
@@ -84,6 +84,9 @@ private static void updateMetricsToLocal(SQLRequest sqlRequest, SQLResponse sqlR
update(getQueryMetrics(projectName), sqlResponse);
String cube = sqlResponse.getCube();
+ if (cube == null) {
Review comment:
updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on a change in pull request #1605: KYLIN-4929 skip update metrics for queries that hit no realization
Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1605:
URL: https://github.com/apache/kylin/pull/1605#discussion_r591974403
##########
File path: server-base/src/main/java/org/apache/kylin/rest/metrics/QueryMetricsFacade.java
##########
@@ -84,6 +84,9 @@ private static void updateMetricsToLocal(SQLRequest sqlRequest, SQLResponse sqlR
update(getQueryMetrics(projectName), sqlResponse);
String cube = sqlResponse.getCube();
+ if (cube == null) {
Review comment:
It's better use `StringUtils.isEmpty(cube)` to check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls commented on pull request #1605: skip update metrics for queries that hit no realization
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1605:
URL: https://github.com/apache/kylin/pull/1605#issuecomment-794803012
## Pull Request Test Coverage Report for [Build 6953](https://coveralls.io/builds/37801716)
* **0** of **2** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **12** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.007%**) to **27.949%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [server-base/src/main/java/org/apache/kylin/rest/metrics/QueryMetricsFacade.java](https://coveralls.io/builds/37801716/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fmetrics%2FQueryMetricsFacade.java#L87) | 0 | 2 | 0.0%
<!-- | **Total:** | **0** | **2** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/37801716/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L193) | 2 | 79.07% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/37801716/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
| [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/37801716/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L46) | 5 | 66.67% |
<!-- | **Total:** | **12** | | -->
| Totals | [](https://coveralls.io/builds/37801716) |
| :-- | --: |
| Change from base [Build 6948](https://coveralls.io/builds/37745441): | -0.007% |
| Covered Lines: | 26251 |
| Relevant Lines: | 93925 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-io commented on pull request #1605: skip update metrics for queries that hit no realization
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1605:
URL: https://github.com/apache/kylin/pull/1605#issuecomment-794797643
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1605?src=pr&el=h1) Report
> Merging [#1605](https://codecov.io/gh/apache/kylin/pull/1605?src=pr&el=desc) (6fdcaac) into [master](https://codecov.io/gh/apache/kylin/commit/02500818d85955b1125340eaa19ab88a634a5181?el=desc) (0250081) will **decrease** coverage by `0.01%`.
> The diff coverage is `7.14%`.
[](https://codecov.io/gh/apache/kylin/pull/1605?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1605 +/- ##
============================================
- Coverage 25.42% 25.40% -0.02%
+ Complexity 6765 6764 -1
============================================
Files 1508 1508
Lines 93918 93925 +7
Branches 13158 13161 +3
============================================
- Hits 23877 23865 -12
- Misses 67662 67678 +16
- Partials 2379 2382 +3
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1605?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1605/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.46% <0.00%> (ø)` | `51.00 <0.00> (ø)` | |
| [...che/kylin/storage/gtrecord/CubeTupleConverter.java](https://codecov.io/gh/apache/kylin/pull/1605/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0N1YmVUdXBsZUNvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/kylin/rest/controller/StreamingV2Controller.java](https://codecov.io/gh/apache/kylin/pull/1605/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9TdHJlYW1pbmdWMkNvbnRyb2xsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apache/kylin/rest/metrics/QueryMetricsFacade.java](https://codecov.io/gh/apache/kylin/pull/1605/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvbWV0cmljcy9RdWVyeU1ldHJpY3NGYWNhZGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/kylin/storage/hbase/HBaseResourceStore.java](https://codecov.io/gh/apache/kylin/pull/1605/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZVJlc291cmNlU3RvcmUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lin/stream/core/query/StreamingTupleConverter.java](https://codecov.io/gh/apache/kylin/pull/1605/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3F1ZXJ5L1N0cmVhbWluZ1R1cGxlQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lin/stream/source/kafka/TimedJsonStreamParser.java](https://codecov.io/gh/apache/kylin/pull/1605/diff?src=pr&el=tree#diff-c3RyZWFtLXNvdXJjZS1rYWZrYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RyZWFtL3NvdXJjZS9rYWZrYS9UaW1lZEpzb25TdHJlYW1QYXJzZXIuamF2YQ==) | `67.39% <0.00%> (ø)` | `12.00 <0.00> (ø)` | |
| [...stream/core/query/MultiThreadsResultCollector.java](https://codecov.io/gh/apache/kylin/pull/1605/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3F1ZXJ5L011bHRpVGhyZWFkc1Jlc3VsdENvbGxlY3Rvci5qYXZh) | `63.91% <66.66%> (+0.37%)` | `4.00 <0.00> (ø)` | |
| [...g/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://codecov.io/gh/apache/kylin/pull/1605/diff?src=pr&el=tree#diff-Y29yZS1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL01ldHJpY3NTeXN0ZW0uamF2YQ==) | `60.00% <0.00%> (-8.34%)` | `17.00% <0.00%> (ø%)` | |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1605/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
| ... and [5 more](https://codecov.io/gh/apache/kylin/pull/1605/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1605?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1605?src=pr&el=footer). Last update [3f3f114...6fdcaac](https://codecov.io/gh/apache/kylin/pull/1605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls edited a comment on pull request #1605: KYLIN-4929 skip update metrics for queries that hit no realization
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1605:
URL: https://github.com/apache/kylin/pull/1605#issuecomment-794803012
## Pull Request Test Coverage Report for [Build 6957](https://coveralls.io/builds/37836371)
* **0** of **3** **(0.0%)** changed or added relevant lines in **2** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage increased (+**0.002%**) to **27.957%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [server-base/src/main/java/org/apache/kylin/rest/metrics/QueryMetrics2Facade.java](https://coveralls.io/builds/37836371/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fmetrics%2FQueryMetrics2Facade.java#L62) | 0 | 1 | 0.0%
| [server-base/src/main/java/org/apache/kylin/rest/metrics/QueryMetricsFacade.java](https://coveralls.io/builds/37836371/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fmetrics%2FQueryMetricsFacade.java#L88) | 0 | 2 | 0.0%
<!-- | **Total:** | **0** | **3** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/37836371/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/37836371) |
| :-- | --: |
| Change from base [Build 6948](https://coveralls.io/builds/37745441): | 0.002% |
| Covered Lines: | 26259 |
| Relevant Lines: | 93925 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1605: KYLIN-4929 skip update metrics for queries that hit no realization
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1605:
URL: https://github.com/apache/kylin/pull/1605
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org