[jira] [Commented] (WW-4636) File upload error message always in default language

["victorsosa (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WW-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299950#comment-15299950 ] 

victorsosa commented on WW-4636:
--------------------------------

the bug right now, it is always using the English  language. Inserting the *Accept-Language: en-US* in the request.

Now it will use the [Content negotiation|https://en.wikipedia.org/wiki/Content_negotiation] to determine which language to use, as it suppose to.

Base on: https://en.wikipedia.org/wiki/Content_negotiation

> File upload error message always in default language
> ----------------------------------------------------
>
>                 Key: WW-4636
>                 URL: https://issues.apache.org/jira/browse/WW-4636
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.3.28
>            Reporter: Pierre-Yves Soblet
>             Fix For: 2.3.29
>
>         Attachments: Struts2i18nTest.zip
>
>
> Struts 2 allows to redefine error messages when an upload fails (as documented in https://cwiki.apache.org/confluence/display/WW/File+Upload).
> For instance, if I upload a file with a size greater than allowed by the configuration using fileUpload interceptor and commons-fileupload dependency, the following key of my resource bundle is used :
> {code}
> struts.messages.upload.error.SizeLimitExceededException=File size exceeded (in i18n.properties).
> {code}
> However, when the current language is not the default one, the translated key (in i18n_fr.properties for instance) is not taken into account (the default language is used instead).
> The issue seems similar to WW-3177 (that was fixed in 2.3.7).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)