You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2023/10/10 09:48:51 UTC
[PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
squakez opened a new pull request, #4812:
URL: https://github.com/apache/camel-k/pull/4812
<!-- Description -->
With this PR we get rid off the very first Kamelets runtime execution which translated the Kamelets into a route templates. We let now the Camel runtime to use the Kamelets as they are expected in the framework.
* Add a configmap as a bundle for all kamelets used by the Integration
* Mount the bundle in /etc/camel/kamelets
* Let the runtime use the Kamelets instead of trasforming into RouteTemplates
* Let the operator use the Kamelet template for capability parsing
Supersedes #4797
Closes #4618
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
feat(trait): let Camel runtime manages Kamelets
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4812:
URL: https://github.com/apache/camel-k/pull/4812#issuecomment-1761512190
:camel: **Thank you for contributing!** :camel:
Unable to create **Coverage Report** :warning:.
Merge conflicts found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4812:
URL: https://github.com/apache/camel-k/pull/4812#issuecomment-1761589041
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage changed: 33.4% --> 33.6% (Coverage difference: **+.2%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on code in PR #4812:
URL: https://github.com/apache/camel-k/pull/4812#discussion_r1354595808
##########
pkg/trait/camel.go:
##########
@@ -238,8 +239,9 @@ func (t *camelTrait) computeConfigMaps(e *Environment) []ctrl.Object {
)
}
- for i, s := range sources {
- if s.ContentRef != "" || e.isEmbedded(s) {
+ i := 0
Review Comment:
A little nitpick out of curiosity: what is the root cause for this change of starting index value from 1 to 0 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4812:
URL: https://github.com/apache/camel-k/pull/4812#issuecomment-1763938473
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage changed: 33.4% --> 33.5% (Coverage difference: **+.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4812:
URL: https://github.com/apache/camel-k/pull/4812#issuecomment-1761528591
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage changed: 33.4% --> 33.6% (Coverage difference: **+.2%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4812:
URL: https://github.com/apache/camel-k/pull/4812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4812:
URL: https://github.com/apache/camel-k/pull/4812#issuecomment-1754852149
@christophd this PR address the point you raised about sources parsing. It should be solved now. Consider that the default properties are no longer required as they are managed by the runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4812:
URL: https://github.com/apache/camel-k/pull/4812#issuecomment-1761255306
:camel: **Thank you for contributing!** :camel:
Unable to create **Coverage Report** :warning:.
Merge conflicts found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4812:
URL: https://github.com/apache/camel-k/pull/4812#discussion_r1354602124
##########
pkg/trait/camel.go:
##########
@@ -238,8 +239,9 @@ func (t *camelTrait) computeConfigMaps(e *Environment) []ctrl.Object {
)
}
- for i, s := range sources {
- if s.ContentRef != "" || e.isEmbedded(s) {
+ i := 0
Review Comment:
the change is not the index itself. The problem is that if we let the variable as implicit part of the loop, it increments also when we skip the source, ie, is embedded, kamelet, etc. But we only want to increment when it is really processed, reason why we need to make it explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on code in PR #4812:
URL: https://github.com/apache/camel-k/pull/4812#discussion_r1354607108
##########
pkg/trait/camel.go:
##########
@@ -238,8 +239,9 @@ func (t *camelTrait) computeConfigMaps(e *Environment) []ctrl.Object {
)
}
- for i, s := range sources {
- if s.ContentRef != "" || e.isEmbedded(s) {
+ i := 0
Review Comment:
Thanks, forget the "1" part, I was mixing with the test result change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4812:
URL: https://github.com/apache/camel-k/pull/4812#issuecomment-1754878184
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage changed: 33.4% --> 33.5% (Coverage difference: **+.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4812:
URL: https://github.com/apache/camel-k/pull/4812#issuecomment-1755590878
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage changed: 33.4% --> 33.5% (Coverage difference: **+.1%**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(trait): let Camel runtime manages Kamelets [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4812:
URL: https://github.com/apache/camel-k/pull/4812#issuecomment-1764368544
Failure does not seem related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org