You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/22 19:36:26 UTC

[GitHub] [airflow] akennedy4155 opened a new issue #21742: Postgres hook uses deprecated parameter from base_aws.py

akennedy4155 opened a new issue #21742:
URL: https://github.com/apache/airflow/issues/21742


   ### Apache Airflow Provider(s)
   
   postgres
   
   ### Versions of Apache Airflow Providers
   
   Most recent
   
   ### Apache Airflow version
   
   2.2.3 (latest released)
   
   ### Operating System
   
   macOS Big Sur 11.3.1
   
   ### Deployment
   
   Astronomer
   
   ### Deployment details
   
   Nothing else needed here.  The source means that this is deployment agnostic I believe.
   
   ### What happened
   
   Postgres hook calls AwsBaseHook, and uses the client_type parameter from the conn cached property.  Using client_type as a parameter here is deprecated, and it should be specified as part of the class initialization I believe.
   
   Warning message is: ```client_type is deprecated. Set client_type from class attribute.```
   
   ### What you expected to happen
   
   No deprecated calls or warning messages.
   
   ### How to reproduce
   
   Use postgres_hook.get_iam_token
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #21742: Postgres hook uses deprecated parameter from base_aws.py

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #21742:
URL: https://github.com/apache/airflow/issues/21742#issuecomment-1048683126


   I don't see the issue. The refrence to client_type is OK
   https://github.com/apache/airflow/blob/3b4c26eb3a1c8d4938be80ab7fa0711561e91f8f/airflow/providers/postgres/hooks/postgres.py#L181
   
   Can you provide example DAG to reproduce the warrning?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal edited a comment on issue #21742: Postgres hook uses deprecated parameter from base_aws.py

Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on issue #21742:
URL: https://github.com/apache/airflow/issues/21742#issuecomment-1048683126


   I don't see the issue. The reference to `client_type` is OK
   https://github.com/apache/airflow/blob/3b4c26eb3a1c8d4938be80ab7fa0711561e91f8f/airflow/providers/postgres/hooks/postgres.py#L181
   
   Can you provide example DAG to reproduce the warning?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org