You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/23 18:18:19 UTC

[GitHub] [spark] rdblue commented on a change in pull request #25568: [SPARK-28238][SQL][FOLLOW-UP] Clean up attributes for Datasource v2 DESCRIBE TABLE

rdblue commented on a change in pull request #25568: [SPARK-28238][SQL][FOLLOW-UP] Clean up attributes for Datasource v2 DESCRIBE TABLE
URL: https://github.com/apache/spark/pull/25568#discussion_r317249041
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
 ##########
 @@ -260,16 +260,16 @@ object DataSourceV2Strategy extends Strategy with PredicateHelper {
         Nil
       }
 
-    case DescribeTable(r: DataSourceV2Relation, isExtended) =>
-      DescribeTableExec(r.table, isExtended) :: Nil
+    case r @ DescribeTable(datasource: DataSourceV2Relation, isExtended) =>
+      DescribeTableExec(r.output, datasource.table, isExtended) :: Nil
 
 Review comment:
   Nit: I'd prefer leaving the relation as `r` and using a better name for the `DescribeTable` node, like `desc`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org