You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Lucene/Solr QA (Jira)" <ji...@apache.org> on 2020/02/05 11:18:00 UTC
[jira] [Commented] (SOLR-14243) ant clean-jars should not delete
gradle-wrapper.jar
[ https://issues.apache.org/jira/browse/SOLR-14243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17030580#comment-17030580 ]
Lucene/Solr QA commented on SOLR-14243:
---------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 0m 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 0m 0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:black}{color} | {color:black} {color} | {color:black} 0m 31s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-14243 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12992681/SOLR-14243-01.patch |
| Optional Tests | compile javac unit ratsources validatesourcepatterns |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh |
| git revision | master / 2d8428ec2e8 |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/679/testReport/ |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/679/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> ant clean-jars should not delete gradle-wrapper.jar
> ---------------------------------------------------
>
> Key: SOLR-14243
> URL: https://issues.apache.org/jira/browse/SOLR-14243
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Andras Salamon
> Priority: Major
> Attachments: SOLR-14243-01.patch
>
>
> Right now ant clean-jars deletes {{gradle/wrapper/gradle-wrapper.jar}}, so if I execute the following command to recreate the checksums it shows up as as deleted file in git:
> {noformat}
> $ ant clean-jars jar-checksums
> ...
> $ git status -s
> D gradle/wrapper/gradle-wrapper.jar{noformat}
> I don't think we should delete the gradle-wrapper.jar here
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org