[GitHub] [spark] juliuszsompolski commented on a change in pull request #25252: [SPARK-28510][SQL] Implement Spark's own GetFunctionsOperation

[GitBox <gi...@apache.org>]

juliuszsompolski commented on a change in pull request #25252: [SPARK-28510][SQL] Implement Spark's own GetFunctionsOperation
URL: https://github.com/apache/spark/pull/25252#discussion_r309255950
 
 

 ##########
 File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java
 ##########
 @@ -150,4 +150,12 @@ public ExpressionInfo(String className, String db, String name, String usage, St
         // simply pass the `extended` as `arguments` and an empty string for `examples`.
         this(className, db, name, usage, extended, "", "", "", "");
     }
+
 
 Review comment:
   I think it's a move in a good direction, as it will make it work better (not return nulls, return actual name instead of placeholder) for anyone using ExpressionInfos directly through `SessionCatalog.lookupFunctionInfo` API directly
   cc @gatorsmile, what do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org