You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2014/09/03 06:38:34 UTC

[GitHub] spark pull request: [SPARK-2781][SQL] Check resolution of LogicalP...

Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/1706#issuecomment-54251313
  
    Hi @staple, thanks for working on this and sorry it took me so long to review it!  Now that the 1.1 release is on its way it would be great to revisit this.  Overall, the changes you propose seem pretty reasonable to me.  A few notes:
     - Can you update it this so that it merged cleanly?
     - We'll need to reconcile this with #1846 (perhaps this should go in after?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org