You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/04/07 07:52:57 UTC

[GitHub] [cassandra] michaelsembwever commented on a change in pull request #953: CASSANDRA-16563 - When behind a firewall trunk is not buildable, need to allow overriding URLs

michaelsembwever commented on a change in pull request #953:
URL: https://github.com/apache/cassandra/pull/953#discussion_r608422692



##########
File path: .build/build-resolver.xml
##########
@@ -67,44 +73,69 @@
             <remoterepo id="resolver-apache" url="${artifact.remoteRepository.apache}"/>
         </resolver:remoterepos>
 
-        <resolver:resolve>
-            <remoterepos refid="all"/>
+        <!-- resolve doesn't really retry, so need to explicitly add extra retries to get stable -->
+        <macrodef name="resolve">
+            <!--
+              Address retries and defaults repos while setting up a resolver:resolve block
+            -->
+            <attribute name="failonmissingattachments" default="true"/>
+            <element name="elements" implicit="yes"/>
+            <sequential>
+                <retry retrycount="3">

Review comment:
       i like it! This is going to strength CI too where I've seen a download fail… 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org