[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1818: SOLR-14819 Trivial fix to inefficient iterator pattern

[GitBox <gi...@apache.org>]

bruno-roustant commented on a change in pull request #1818:
URL: https://github.com/apache/lucene-solr/pull/1818#discussion_r482036367



##########
File path: solr/solrj/src/java/org/apache/solr/common/util/JsonSchemaValidator.java
##########
@@ -48,13 +48,15 @@ public JsonSchemaValidator(String jsonString) {
 
   public JsonSchemaValidator(Map jsonSchema) {
     this.validators = new LinkedList<>();
-    for (Object fname : jsonSchema.keySet()) {
+    for (Object entry : jsonSchema.entrySet()) {

Review comment:
       +1 (same for the other loop below)

##########
File path: .muse.toml
##########
@@ -0,0 +1 @@
+jdk11 = true

Review comment:
       Please remove this from the PR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org