You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by lerouxrgd <gi...@git.apache.org> on 2016/05/20 16:18:36 UTC

[GitHub] storm pull request: fix for PartitionedTridentSpoutExecutor STORM-...

GitHub user lerouxrgd opened a pull request:

    https://github.com/apache/storm/pull/1438

    fix for PartitionedTridentSpoutExecutor STORM-1728

    UT passed locally for storm-core and storm-kafka.
    Also tested in a dev setup (Storm and Kafka running locally).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lerouxrgd/storm fix/transactional-trident-kafka-spout

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1438.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1438
    
----
commit 2482a419e9bbe6864f4cf4f5d16e8c5836366d60
Author: lerouxrgd <le...@gmail.com>
Date:   2016-05-20T16:14:38Z

    fix for PartitionedTridentSpoutExecutor STORM-1728

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: fix for PartitionedTridentSpoutExecutor STORM-...

Posted by lerouxrgd <gi...@git.apache.org>.
Github user lerouxrgd closed the pull request at:

    https://github.com/apache/storm/pull/1438


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: fix for PartitionedTridentSpoutExecutor STORM-...

Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/1438#issuecomment-220656428
  
    @lerouxrgd Thanks for the patch, but this looks like a duplicate of #1429 which is eligible for merge. Would you mind closing this PR?
    
    The earlier PR was raised when we had Github-JIRA integration issues, which is why it didn't show up as a JIRA comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---