[GitHub] [iceberg] rdblue commented on a diff in pull request #6562: Core: Improvements around Token Refresh time expiration

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6562:
URL: https://github.com/apache/iceberg/pull/6562#discussion_r1073791890


##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -126,8 +127,7 @@ public void initialize(String name, Map<String, String> unresolved) {
     // catalog service
     Map<String, String> props = EnvironmentUtil.resolveAll(unresolved);
 
-    long startTimeMillis =
-        System.currentTimeMillis(); // keep track of the init start time for token refresh
+    Instant startTime = Instant.now(); // keep track of the init start time for token refresh

Review Comment:
   Throughout Iceberg, we use `System.currentTimeMillis()`. Is there a reason to deviate from that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org