[jira] [Closed] (ORC-1026) when write string type column,there is no need to traversing the dictionary when flushDictionary method is called

["qingbo jiao (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ORC-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

qingbo jiao closed ORC-1026.
----------------------------
    Resolution: Not A Bug

> when write string type column,there is no need to traversing the dictionary when flushDictionary method is called
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: ORC-1026
>                 URL: https://issues.apache.org/jira/browse/ORC-1026
>             Project: ORC
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 1.8.0
>            Reporter: qingbo jiao
>            Priority: Major
>
> In the StringBaseTreeWriter.class when called flushDictionary() method，where traversing the dictionary as show below
> {code:java}
> dictionary.visit(new Dictionary.Visitor() {
>   private int currentId = 0;
>   @Override
>   public void visit(Dictionary.VisitorContext context
>   ) throws IOException {
>     context.writeBytes(stringOutput);
>     lengthOutput.write(context.getLength());
>     dumpOrder[context.getOriginalPosition()] = currentId++;
>   }
> });
> {code}
> I think this is not needed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)