You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/09/26 06:50:00 UTC

[jira] [Commented] (PHOENIX-7051) Remove direct dependeny on Google Guice from phoenix-core

    [ https://issues.apache.org/jira/browse/PHOENIX-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769030#comment-17769030 ] 

ASF GitHub Bot commented on PHOENIX-7051:
-----------------------------------------

stoty opened a new pull request, #1692:
URL: https://github.com/apache/phoenix/pull/1692

   also bump dependencyManaged version to 5.1, and simplify handling in pom




> Remove direct dependeny on Google Guice from phoenix-core
> ---------------------------------------------------------
>
>                 Key: PHOENIX-7051
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7051
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>            Reporter: Istvan Toth
>            Priority: Critical
>
> Google guice is used in a single location.
> Remove it, and remove the direct dependency.
> Omid uses Guice extensively, and it looks like we need it for tests, and also on the runtime classpath
> but there is no reason to let it spread further into the runtime codebase.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)