You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Joel Koshy <jj...@gmail.com> on 2014/04/22 00:40:52 UTC

Review Request 20538: Patch for KAFKA-1380

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20538/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1380
    https://issues.apache.org/jira/browse/KAFKA-1380


Repository: kafka


Description
-------

KAFKA-1327; Log cleaner metrics follow-up patch to reset dirtiest log cleanable ratio.


Diffs
-----

  core/src/main/scala/kafka/log/LogCleaner.scala b9ffe00d6c656476ed4c4e6f68fb2ba115090c92 
  core/src/main/scala/kafka/log/LogCleanerManager.scala 683d7225077074d2a797af29784d31e5224e6181 

Diff: https://reviews.apache.org/r/20538/diff/


Testing
-------


Thanks,

Joel Koshy

Re: Review Request 20538: Patch for KAFKA-1380

Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20538/#review40978
-----------------------------------------------------------

Ship it!


Ship It!

- Jun Rao


On April 21, 2014, 10:40 p.m., Joel Koshy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20538/
> -----------------------------------------------------------
> 
> (Updated April 21, 2014, 10:40 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1380
>     https://issues.apache.org/jira/browse/KAFKA-1380
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1327; Log cleaner metrics follow-up patch to reset dirtiest log cleanable ratio.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/log/LogCleaner.scala b9ffe00d6c656476ed4c4e6f68fb2ba115090c92 
>   core/src/main/scala/kafka/log/LogCleanerManager.scala 683d7225077074d2a797af29784d31e5224e6181 
> 
> Diff: https://reviews.apache.org/r/20538/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joel Koshy
> 
>