[GitHub] [skywalking] jinho-son commented on issue #9691: [Bug] OpenTelemetryMetricHandler Histogram buildBucket

[GitBox <gi...@apache.org>]

jinho-son commented on issue #9691:
URL: https://github.com/apache/skywalking/issues/9691#issuecomment-1260260053

   I think in OpenTelemetry Histogram, it's not cumulative.(The meaning of 'cumulative' is cumulative increase bucket counts like prometheus)
   
   There are several reasons.
   1. bucket_counts
   In the opentelemetry proto file. [proto-bucket_counts](https://github.com/open-telemetry/opentelemetry-proto/blob/c5c8b28012583fda55b0cb16f73a820722171d49/opentelemetry/proto/metrics/v1/metrics.proto#L467)
   If opentelemetry bucket like prometheus style, only last bucket_count equal the value in the count field.
   But the opentelemetry-proto comments 'The sum of bucket_counts must equal the value in the count field'.
   
   2. explicit_bounds
   In the opentelemetry proto file. [proto-explicit_bounds](https://github.com/open-telemetry/opentelemetry-proto/blob/c5c8b28012583fda55b0cb16f73a820722171d49/opentelemetry/proto/metrics/v1/metrics.proto#L478)
   If the opentelemetry bounds like prometheus style, it will be says lower or equal than specific bound.
   But the opentelemetry-proto comments like specific ranges '(explicit_bounds[i-1], explicit_bounds[i]] for 0 < i < size(explicit_bounds)'
   
   3. opentelemetry docs
   The OpenTelemetry docs of [Histogram](https://opentelemetry.io/docs/reference/specification/metrics/datamodel/#histogram-bucket-inclusivity)
   ` That is, buckets express the number of values that are greater than their lower bound and less than or equal to their upper bound`
   
   Am I misunderstand?
   
   Also 
   AggregationTemporality: AGGREGATION_TEMPORALITY_DELTA
   AggregationTemporality: AGGREGATION_TEMPORALITY_CUMULATIVE
   
   It means time based delta or cumulative
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org