You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by gosubpl <gi...@git.apache.org> on 2017/06/18 21:28:22 UTC
[GitHub] zookeeper pull request #285: ZOOKEEPER-2730: Disable i18n warnings until the...
GitHub user gosubpl opened a pull request:
https://github.com/apache/zookeeper/pull/285
ZOOKEEPER-2730: Disable i18n warnings until they can be fixed in a sy…
…stematic manner
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gosubpl/zookeeper ZOOKEEPER-2730
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/285.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #285
----
commit c37e3a815ff8c66d0216ec6949031d6626b45cd5
Author: gosubpl <gi...@gosub.pl>
Date: 2017-06-18T21:27:20Z
ZOOKEEPER-2730: Disable i18n warnings until they can be fixed in a systematic manner
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #285: ZOOKEEPER-2730: Disable i18n warnings until the...
Posted by gosubpl <gi...@git.apache.org>.
Github user gosubpl closed the pull request at:
https://github.com/apache/zookeeper/pull/285
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #285: ZOOKEEPER-2730: Disable i18n warnings until they can b...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/285
lgtm. Until there is a solution to fix root problem, I don't see why we should not get this in 3.4 given the same fix has been applied to 3.5 and trunk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #285: ZOOKEEPER-2730: Disable i18n warnings until they can b...
Posted by rakeshadr <gi...@git.apache.org>.
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/285
Thanks @gosubpl
Thanks @hanm for the reviews. I'll merge this shortly.
I could see, this was pushed to `branch 3.5`+ via ZOOKEEPER-1975, nobody might have noticed this in branch-3.4 and missed back porting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #285: ZOOKEEPER-2730: Disable i18n warnings until they can b...
Posted by rakeshadr <gi...@git.apache.org>.
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/285
@gosubpl , I've merged it and please close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #285: ZOOKEEPER-2730: Disable i18n warnings until they can b...
Posted by gosubpl <gi...@git.apache.org>.
Github user gosubpl commented on the issue:
https://github.com/apache/zookeeper/pull/285
@hanm @rakeshadr many thanks! Closing now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---