You are viewing a plain text version of this content. The canonical link for it is here.
Posted to taglibs-dev@jakarta.apache.org by bu...@apache.org on 2006/06/05 07:17:23 UTC

DO NOT REPLY [Bug 39719] New: - JstlCoreTLV is too strict in its requirements

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39719>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39719

           Summary: JstlCoreTLV is too strict in its requirements
           Product: Taglibs
           Version: 1.2.0
          Platform: All
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Standard Taglib
        AssignedTo: taglibs-dev@jakarta.apache.org
        ReportedBy: james.a.rosen@gmail.com


Lines 194 and following of org.apache.taglibs.standard.tlv.JstlCoreTLV read as
follows:

---
// check constraints for <param> vis-a-vis URL-related tags
if (isCoreTag(ns, ln, PARAM)) {
  // no <param> outside URL tags.
  if (urlTags.empty() || urlTags.peek().equals(PARAM))
    fail(Resources.getMessage("TLV_ILLEGAL_ORPHAN", PARAM));
---

This is too strict.  The class
org.apache.taglibs.standard.tag.common.core.ParamSupport only requires that its
parent implement ParamParent, not actually be a c:url tag.  With the TLV as is,
I cannot write another tag of my own that relies on c:param tags internally.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 39719] - JstlCoreTLV is too strict in its requirements

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39719>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39719


bayard@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX




------- Additional Comments From bayard@apache.org  2007-03-14 16:33 -------
Reported to the Glassfish Ref Impl as:

https://glassfish.dev.java.net/issues/show_bug.cgi?id=2615

Closing this issue as WONTFIX.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 39719] - JstlCoreTLV is too strict in its requirements

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39719>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39719





------- Additional Comments From bayard@apache.org  2006-12-06 16:21 -------
Looking at the code, relaxing this isn't very simple as we're not at the object
level. Instead we're parsing XML in SAX, so it's not known that the allowed
"param" parents of "url", "import" and "redirect" all implement ParamParent.

There's no change to the spec in 1.2 on the c:param page, so nothing to be
learnt there.

The choice seems to me to be either to remove the TLV check for the parent of
c:param or to recommend that people create their own *:param tags by extending
the ParamTag implementations. 

My suggestion is that we do the latter while bringing the former up as an issue
for the expert group.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org