You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by dw...@apache.org on 2022/02/04 12:02:14 UTC
[flink] 02/02: [FLINK-21752] Add a call to TypeSerializer#duplicate in migration tests
This is an automated email from the ASF dual-hosted git repository.
dwysakowicz pushed a commit to branch release-1.14
in repository https://gitbox.apache.org/repos/asf/flink.git
commit b9f7a4f02e969cf98d7b3acc549b27adad234079
Author: Dawid Wysakowicz <dw...@apache.org>
AuthorDate: Thu Feb 3 12:25:07 2022 +0100
[FLINK-21752] Add a call to TypeSerializer#duplicate in migration tests
We should verify that a TypeSerializer even after migration can be
safely duplicated. In order to do that we can duplicate a new serializer
in the TypeSerializerUpgradeTestBase before we try to use for
deserialization.
---
.../flink/api/common/typeutils/TypeSerializerUpgradeTestBase.java | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/flink-core/src/test/java/org/apache/flink/api/common/typeutils/TypeSerializerUpgradeTestBase.java b/flink-core/src/test/java/org/apache/flink/api/common/typeutils/TypeSerializerUpgradeTestBase.java
index 0dbe642..0c5ad47 100644
--- a/flink-core/src/test/java/org/apache/flink/api/common/typeutils/TypeSerializerUpgradeTestBase.java
+++ b/flink-core/src/test/java/org/apache/flink/api/common/typeutils/TypeSerializerUpgradeTestBase.java
@@ -421,7 +421,13 @@ public abstract class TypeSerializerUpgradeTestBase<PreviousElementT, UpgradedEl
readAndThenWriteData(dataInput, serializer, serializer, testDataMatcher);
TypeSerializerSnapshot<T> snapshot = writeAndThenReadSerializerSnapshot(serializer);
TypeSerializer<T> restoreSerializer = snapshot.restoreSerializer();
- readAndThenWriteData(serializedData, restoreSerializer, restoreSerializer, testDataMatcher);
+ serializedData =
+ readAndThenWriteData(
+ serializedData, restoreSerializer, restoreSerializer, testDataMatcher);
+
+ TypeSerializer<T> duplicateSerializer = snapshot.restoreSerializer().duplicate();
+ readAndThenWriteData(
+ serializedData, duplicateSerializer, duplicateSerializer, testDataMatcher);
}
// ------------------------------------------------------------------------------