[GitHub] [hive] pvary commented on a change in pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #1958:
URL: https://github.com/apache/hive/pull/1958#discussion_r580321214



##########
File path: beeline/src/main/resources/beeline-log4j2.properties
##########
@@ -33,12 +33,16 @@ appender.console.layout.type = PatternLayout
 appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} [%t]: %p %c{2}: %m%n
 
 # list of all loggers
-loggers = HiveConnection
+loggers = HiveConnection, HiveStatement
 
 # HiveConnection logs useful info for dynamic service discovery
 logger.HiveConnection.name = org.apache.hive.jdbc.HiveConnection
 logger.HiveConnection.level = INFO
 
+# HiveStatement logs for tracking the running statement, such as the operation's drilldown link
+logger.HiveStatement.name = org.apache.hive.jdbc.HiveStatement

Review comment:
       @dengzhhu653: I think showing the link should be decided based on this method:
   ```
   if (sessionManager.getOperationManager().canShowDrilldownLink(operationHandle)) {
   ```
   Are you saying that this is not working as expected? Even if the config is enabled and the line is appended to the info messages then it is not displayed on BeeLine?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org