[GitHub] [iotdb] wangchao316 commented on a change in pull request #2744: remove redundant call of sealCurrentPage().

[GitBox <gi...@apache.org>]

wangchao316 commented on a change in pull request #2744:
URL: https://github.com/apache/iotdb/pull/2744#discussion_r584012503



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java
##########
@@ -271,7 +270,7 @@ public void run() {
             storageGroup,
             writer.getFile().getName());
         while (true) {
-          Object ioMessage = null;

Review comment:
       local var init...this do not have problem...

##########
File path: server/src/main/java/org/apache/iotdb/db/engine/flush/MemTableFlushTask.java
##########
@@ -237,7 +237,6 @@ public void run() {
                   (Pair<TVList, MeasurementSchema>) task;
               IChunkWriter seriesWriter = new ChunkWriterImpl(encodingMessage.right);
               writeOneSeries(encodingMessage.left, seriesWriter, encodingMessage.right.getType());
-              seriesWriter.sealCurrentPage();

Review comment:
       this code can not delete.  because this  method make encode data...
   this will lead to encode problem...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org