You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 09:39:17 UTC
[GitHub] [airflow] AlessioM opened a new pull request #13536: fix string encoding when using xcom / json
AlessioM opened a new pull request #13536:
URL: https://github.com/apache/airflow/pull/13536
closes: #13535
fixes the xcom issue by decoding the byte array of the log file before submitting it to xcom
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-756071292
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-764594469
[The Workflow run](https://github.com/apache/airflow/actions/runs/500979543) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AlessioM commented on a change in pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
AlessioM commented on a change in pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#discussion_r554932857
##########
File path: tests/providers/docker/operators/test_docker.py
##########
@@ -244,7 +244,7 @@ def test_execute_xcom_behavior(self):
xcom_push_result = xcom_push_operator.execute(None)
no_xcom_push_result = no_xcom_push_operator.execute(None)
- self.assertEqual(xcom_push_result, b'container log')
+ self.assertEqual(xcom_push_result, 'container log')
Review comment:
_run_image of the DockerOperator returns now a python string, not a byte string (otherwise the json encoding fails)
but the unit test did check for a byte string
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#discussion_r554872177
##########
File path: tests/providers/docker/operators/test_docker.py
##########
@@ -244,7 +244,7 @@ def test_execute_xcom_behavior(self):
xcom_push_result = xcom_push_operator.execute(None)
no_xcom_push_result = no_xcom_push_operator.execute(None)
- self.assertEqual(xcom_push_result, b'container log')
+ self.assertEqual(xcom_push_result, 'container log')
Review comment:
I think this may be a breaking change, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#discussion_r554948512
##########
File path: tests/providers/docker/operators/test_docker.py
##########
@@ -244,7 +244,7 @@ def test_execute_xcom_behavior(self):
xcom_push_result = xcom_push_operator.execute(None)
no_xcom_push_result = no_xcom_push_operator.execute(None)
- self.assertEqual(xcom_push_result, b'container log')
+ self.assertEqual(xcom_push_result, 'container log')
Review comment:
I know, but changing this type is a breaking change. Assuming users used pickle as XCom they were able to pickle that, end then they possibily used `decoded` method which is unavailable for `str` type, so something like this:
```py
the_output_from_xcom.decode("utf-8")
```
won't work, am I right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-764593808
[The Workflow run](https://github.com/apache/airflow/actions/runs/500978316) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13536:
URL: https://github.com/apache/airflow/pull/13536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AlessioM commented on a change in pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
AlessioM commented on a change in pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#discussion_r555000780
##########
File path: tests/providers/docker/operators/test_docker.py
##########
@@ -244,7 +244,7 @@ def test_execute_xcom_behavior(self):
xcom_push_result = xcom_push_operator.execute(None)
no_xcom_push_result = no_xcom_push_operator.execute(None)
- self.assertEqual(xcom_push_result, b'container log')
+ self.assertEqual(xcom_push_result, 'container log')
Review comment:
also: I don't think the `... else line.encode('utf-8')` is correct,
line is the last element returned from the docker client attach call, according to the airflow documentation xcom should contain the last line if xcom_all is False, but I don't see this happening
see:
https://github.com/docker/docker-py/blob/6da140e26c1cbe8e362b328b1c78d9c736f3a1a2/docker/api/container.py#L17
##########
File path: tests/providers/docker/operators/test_docker.py
##########
@@ -244,7 +244,7 @@ def test_execute_xcom_behavior(self):
xcom_push_result = xcom_push_operator.execute(None)
no_xcom_push_result = no_xcom_push_operator.execute(None)
- self.assertEqual(xcom_push_result, b'container log')
+ self.assertEqual(xcom_push_result, 'container log')
Review comment:
ok, yes
if we want to keep xcom results as byte strings, then we have to decode the byte string right before logging it to json, here:
https://github.com/apache/airflow/blob/master/airflow/models/xcom.py#L235
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sti0 removed a comment on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
sti0 removed a comment on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-758152962
Maybe it's possible to look if [pickling](https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#enable-xcom-pickling) is activated and then return a byte object, otherwise a string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sti0 commented on a change in pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
sti0 commented on a change in pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#discussion_r555268657
##########
File path: tests/providers/docker/operators/test_docker.py
##########
@@ -244,7 +244,7 @@ def test_execute_xcom_behavior(self):
xcom_push_result = xcom_push_operator.execute(None)
no_xcom_push_result = no_xcom_push_operator.execute(None)
- self.assertEqual(xcom_push_result, b'container log')
+ self.assertEqual(xcom_push_result, 'container log')
Review comment:
Maybe it's possible to look if [pickling](https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#enable-xcom-pickling) is activated and then return a byte object, otherwise a string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#discussion_r554948512
##########
File path: tests/providers/docker/operators/test_docker.py
##########
@@ -244,7 +244,7 @@ def test_execute_xcom_behavior(self):
xcom_push_result = xcom_push_operator.execute(None)
no_xcom_push_result = no_xcom_push_operator.execute(None)
- self.assertEqual(xcom_push_result, b'container log')
+ self.assertEqual(xcom_push_result, 'container log')
Review comment:
I know, but changing this type is a breaking change. Assuming users used pickle as XCom they were able to pickle that, and then they possibily used `decoded` method which is unavailable for `str` type, so something like this:
```py
the_output_from_xcom.decode("utf-8")
```
won't work, am I right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-886876892
I simplified it a bit more (there was no need to use logs, It's much simpler if we used already available array of potentially decoded lines and added more comprehensive tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cjk commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
cjk commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-817720826
I'm still running into #13487 in Airflow 2.0.1 - hope this gets merged soon. :pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-776912656
@AlessioM can you please rebase on master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AlessioM commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
AlessioM commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-780806403
> @AlessioM can you please rebase on master?
sorry for taking so long, done just now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AlessioM commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
AlessioM commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-831927367
sorry,that it takes so long, hard to find time at the moment
we are running the patch in production at the moment and are currently investigating an issue with German Umlauts in log messages. Not sure yet if its because of this fix or some other issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13536: fix string encoding when using xcom / json
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-756002895
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#discussion_r556329300
##########
File path: tests/providers/docker/operators/test_docker.py
##########
@@ -244,7 +244,7 @@ def test_execute_xcom_behavior(self):
xcom_push_result = xcom_push_operator.execute(None)
no_xcom_push_result = no_xcom_push_operator.execute(None)
- self.assertEqual(xcom_push_result, b'container log')
+ self.assertEqual(xcom_push_result, 'container log')
Review comment:
@AlessioM I think we should merge this PR which fixes the operator - there's no problem with current XCom implementation.
As per breaking change we can do this - we just need an info about it in ADDITIONAL_INFO.md in docker provider.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] enima2684 commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
enima2684 commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-781190815
Many thanks for working on that issue !
Looking forward to use the fix !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fsalvini commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
fsalvini commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-817657890
Hi @AlessioM, thank you very much for this fix.
Will you be able to find the time to complete this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
RosterIn commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-819312274
@AlessioM you will need to rebase to fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
RosterIn commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-831913274
hi @kaxil @AlessioM @turbaszek is there a way to make progress with this fix?
This ismuch needed I don't mind open a new PR copying the code here so it can be finally merged but it seems like rebase this is very simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-764593808
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on a change in pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
RosterIn commented on a change in pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#discussion_r578249723
##########
File path: airflow/providers/docker/ADDITIONAL_INFO.md
##########
@@ -23,3 +23,7 @@
* `Remove failed DockerOperator tasks with auto_remove=True (#13532) (#13993)`
* `Fix error on DockerSwarmOperator with auto_remove True (#13532) (#13852)`
+### Changes to XCom return values
+
+* the return value of XCom is of type `str` (as opposed to `bytes`)
+* if `xcom_all` is set to `False` only the last line of the log (separated by `\n`) will be included in the XCom value
Review comment:
```suggestion
* if `xcom_all` is set to `False` only the last line of the log (separated by `\n`) will be included in the XCom value
```
add new line at end of file to make test green
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-886809562
I rebased and pushed it @AlessioM :) (I also changed ADDITIONAL_INFO to CHANGELOG :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-886907121
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fredthomsen commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
fredthomsen commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-886767404
I am curious as to the issues/log messages being encountered here. I have had to patch our `DockerOperator` using this version and it seems to be running without issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AlessioM commented on a change in pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
AlessioM commented on a change in pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#discussion_r555763984
##########
File path: tests/providers/docker/operators/test_docker.py
##########
@@ -244,7 +244,7 @@ def test_execute_xcom_behavior(self):
xcom_push_result = xcom_push_operator.execute(None)
no_xcom_push_result = no_xcom_push_operator.execute(None)
- self.assertEqual(xcom_push_result, b'container log')
+ self.assertEqual(xcom_push_result, 'container log')
Review comment:
I created an alternative fix, way simpler actually to fix it in the xcom.py at the point of serialization:
https://github.com/apache/airflow/pull/13635
I'd suggest going from there and closing this one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sti0 commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
sti0 commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-758152962
Maybe it's possible to look if [pickling](https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#enable-xcom-pickling) is activated and then return a byte object, otherwise a string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13536: Fix string encoding in DockerOperator when using xcom / json
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#issuecomment-886769833
@AlessioM I will rebase it for you (as I added some changes in Docker Operator) - I am just about to FINALLY release RC2 of providers so I would love to get that one in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org