You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by caiqiang <qi...@qq.com> on 2016/10/24 07:43:10 UTC
please vote and comment: remove thrift solution
Hi
Currently, There are two typical Thrift issues:
1.Users want to directly build Apache CarbonData, don’t need to install Thrift in advance. For example:
Julian Hyde-3’s feedback in IPMC mailing list: I was not able to build (not your fault - I did not have thrift
installed and didn't have the time & patience to install it).
2.Need to fix Apache Jenkins CI issues, as below:
[ERROR] Failed to execute goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile (generate-thrift-java) on project carbondata-format: thrift did not exit cleanly. Review output for more information. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile (generate-thrift-java) on project carbondata-format: thrift did not exit cleanly. Review output for more information.
For solving the above mentioned Thrift issues, i would like to propose one solution: Directly use java code ( thrift compiler compile carbondata format files to java code) to build, then users don't need to do any thrift installation.
please vote and comment :
To continue use the current manual install method to build
or
To directly use java code which be generated by thrift compiler to build
Re: please vote and comment: remove thrift solution
Posted by QiangCai <qi...@qq.com>.
After discussion, the result as following
Solution:
- Use jars published in Apache repository
Rejected Solution:
- Directly use source code
--
View this message in context: http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/please-vote-and-comment-remove-thrift-solution-tp2253p2286.html
Sent from the Apache CarbonData Mailing List archive mailing list archive at Nabble.com.
Re: please vote and comment: remove thrift solution
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Agree.
Regards
JB
\u2063\u200b
On Oct 25, 2016, 10:47, at 10:47, Liang Chen <ch...@gmail.com> wrote:
>Hi
>
>Yes, This solution is better by providing only the jar dependency of
>thrift generated jar from repo.
>
>Regards
>Liang
>
>
>ravipesala wrote
>> Hi David,
>>
>> I guess keeping the generated code in apache github may not be a good
>> solution, even I am not sure whether it is acceptable to keep
>generated
>> code in apache.
>>
>> I prefer to decouple the thrift code compilation from main build and
>> provide separate profile to do thrift compilation and upload the jar
>to
>> repository. And in the main build we provide only the jar dependency
>of
>> thrift generated jar from repo. If anybody wants to change the
>thrift
>> format code then he can compile thrift format code by using separate
>maven
>> profile and upload the jar to snapshot repo.
>>
>>
>> Thanks,
>> Ravi.
>>
>> On 24 October 2016 at 14:09, Liang Chen <
>
>> chenliang6136@
>
>> > wrote:
>>
>>> Hi
>>>
>>> I prefer to the new solution for fixing thrift issues:Directly use
>java
>>> code
>>> ( thrift compiler compile carbondata format files to java code) to
>>> build,
>>> then users don't need to do any thrift installation.
>>>
>>> +1 for new solution.
>>>
>>> Regards
>>> Liang
>>>
>>> QiangCai wrote
>>> > Hi
>>> >
>>> > Currently, There are two typical Thrift issues:
>>> >
>>> > 1.Users want to directly build Apache CarbonData, don\u2019t need to
>install
>>> > Thrift in advance. For example:
>>> >
>>> > Julian Hyde-3\u2019s feedback in IPMC mailing list: I was not able to
>build
>>> > (not your fault - I did not have thrift
>>> > installed and didn't have the time & patience to install it).
>>> >
>>> > 2.Need to fix Apache Jenkins CI issues, as below:
>>> >
>>> > [ERROR] Failed to execute goal
>>> > org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
>>> > (generate-thrift-java) on project carbondata-format: thrift did
>not
>>> exit
>>> > cleanly. Review output for more information. -> [Help 1]
>>> >
>>> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>>> execute
>>> > goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
>>> > (generate-thrift-java) on project carbondata-format: thrift did
>not
>>> exit
>>> > cleanly. Review output for more information.
>>> >
>>> > For solving the above mentioned Thrift issues, i would like to
>propose
>>> one
>>> > solution: Directly use java code ( thrift compiler compile
>carbondata
>>> > format files to java code) to build, then users don't need to do
>any
>>> > thrift installation.
>>> >
>>> > please vote and comment :
>>> >
>>> > To continue use the current manual install method to build
>>> >
>>> > or
>>> >
>>> > To directly use java code which be generated by thrift compiler to
>>> build
>>>
>>>
>>>
>>>
>>>
>>> --
>>> View this message in context: http://apache-carbondata-
>>> mailing-list-archive.1130556.n5.nabble.com/please-vote-and-
>>> comment-remove-thrift-solution-tp2253p2254.html
>>> Sent from the Apache CarbonData Mailing List archive mailing list
>archive
>>> at Nabble.com.
>>>
>>
>>
>>
>> --
>> Thanks & Regards,
>> Ravi
>
>
>
>
>
>--
>View this message in context:
>http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/please-vote-and-comment-remove-thrift-solution-tp2253p2284.html
>Sent from the Apache CarbonData Mailing List archive mailing list
>archive at Nabble.com.
Re: please vote and comment: remove thrift solution
Posted by Liang Chen <ch...@gmail.com>.
Hi
Yes, This solution is better by providing only the jar dependency of
thrift generated jar from repo.
Regards
Liang
ravipesala wrote
> Hi David,
>
> I guess keeping the generated code in apache github may not be a good
> solution, even I am not sure whether it is acceptable to keep generated
> code in apache.
>
> I prefer to decouple the thrift code compilation from main build and
> provide separate profile to do thrift compilation and upload the jar to
> repository. And in the main build we provide only the jar dependency of
> thrift generated jar from repo. If anybody wants to change the thrift
> format code then he can compile thrift format code by using separate maven
> profile and upload the jar to snapshot repo.
>
>
> Thanks,
> Ravi.
>
> On 24 October 2016 at 14:09, Liang Chen <
> chenliang6136@
> > wrote:
>
>> Hi
>>
>> I prefer to the new solution for fixing thrift issues:Directly use java
>> code
>> ( thrift compiler compile carbondata format files to java code) to
>> build,
>> then users don't need to do any thrift installation.
>>
>> +1 for new solution.
>>
>> Regards
>> Liang
>>
>> QiangCai wrote
>> > Hi
>> >
>> > Currently, There are two typical Thrift issues:
>> >
>> > 1.Users want to directly build Apache CarbonData, don’t need to install
>> > Thrift in advance. For example:
>> >
>> > Julian Hyde-3’s feedback in IPMC mailing list: I was not able to build
>> > (not your fault - I did not have thrift
>> > installed and didn't have the time & patience to install it).
>> >
>> > 2.Need to fix Apache Jenkins CI issues, as below:
>> >
>> > [ERROR] Failed to execute goal
>> > org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
>> > (generate-thrift-java) on project carbondata-format: thrift did not
>> exit
>> > cleanly. Review output for more information. -> [Help 1]
>> >
>> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>> execute
>> > goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
>> > (generate-thrift-java) on project carbondata-format: thrift did not
>> exit
>> > cleanly. Review output for more information.
>> >
>> > For solving the above mentioned Thrift issues, i would like to propose
>> one
>> > solution: Directly use java code ( thrift compiler compile carbondata
>> > format files to java code) to build, then users don't need to do any
>> > thrift installation.
>> >
>> > please vote and comment :
>> >
>> > To continue use the current manual install method to build
>> >
>> > or
>> >
>> > To directly use java code which be generated by thrift compiler to
>> build
>>
>>
>>
>>
>>
>> --
>> View this message in context: http://apache-carbondata-
>> mailing-list-archive.1130556.n5.nabble.com/please-vote-and-
>> comment-remove-thrift-solution-tp2253p2254.html
>> Sent from the Apache CarbonData Mailing List archive mailing list archive
>> at Nabble.com.
>>
>
>
>
> --
> Thanks & Regards,
> Ravi
--
View this message in context: http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/please-vote-and-comment-remove-thrift-solution-tp2253p2284.html
Sent from the Apache CarbonData Mailing List archive mailing list archive at Nabble.com.
Re: please vote and comment: remove thrift solution
Posted by Ravindra Pesala <ra...@gmail.com>.
Hi David,
I guess keeping the generated code in apache github may not be a good
solution, even I am not sure whether it is acceptable to keep generated
code in apache.
I prefer to decouple the thrift code compilation from main build and
provide separate profile to do thrift compilation and upload the jar to
repository. And in the main build we provide only the jar dependency of
thrift generated jar from repo. If anybody wants to change the thrift
format code then he can compile thrift format code by using separate maven
profile and upload the jar to snapshot repo.
Thanks,
Ravi.
On 24 October 2016 at 14:09, Liang Chen <ch...@gmail.com> wrote:
> Hi
>
> I prefer to the new solution for fixing thrift issues:Directly use java
> code
> ( thrift compiler compile carbondata format files to java code) to build,
> then users don't need to do any thrift installation.
>
> +1 for new solution.
>
> Regards
> Liang
>
> QiangCai wrote
> > Hi
> >
> > Currently, There are two typical Thrift issues:
> >
> > 1.Users want to directly build Apache CarbonData, don’t need to install
> > Thrift in advance. For example:
> >
> > Julian Hyde-3’s feedback in IPMC mailing list: I was not able to build
> > (not your fault - I did not have thrift
> > installed and didn't have the time & patience to install it).
> >
> > 2.Need to fix Apache Jenkins CI issues, as below:
> >
> > [ERROR] Failed to execute goal
> > org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
> > (generate-thrift-java) on project carbondata-format: thrift did not exit
> > cleanly. Review output for more information. -> [Help 1]
> >
> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
> execute
> > goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
> > (generate-thrift-java) on project carbondata-format: thrift did not exit
> > cleanly. Review output for more information.
> >
> > For solving the above mentioned Thrift issues, i would like to propose
> one
> > solution: Directly use java code ( thrift compiler compile carbondata
> > format files to java code) to build, then users don't need to do any
> > thrift installation.
> >
> > please vote and comment :
> >
> > To continue use the current manual install method to build
> >
> > or
> >
> > To directly use java code which be generated by thrift compiler to build
>
>
>
>
>
> --
> View this message in context: http://apache-carbondata-
> mailing-list-archive.1130556.n5.nabble.com/please-vote-and-
> comment-remove-thrift-solution-tp2253p2254.html
> Sent from the Apache CarbonData Mailing List archive mailing list archive
> at Nabble.com.
>
--
Thanks & Regards,
Ravi
Re: please vote and comment: remove thrift solution
Posted by Vimal Das Kammath <vi...@gmail.com>.
+1 for directly using java code to build.
At the same time, we should have the CI infrastructure to ensure that the
.thrift files and the generated source code are always in sync.
Regards
Vimal
On Mon, Oct 24, 2016 at 2:09 PM, Liang Chen <ch...@gmail.com> wrote:
> Hi
>
> I prefer to the new solution for fixing thrift issues:Directly use java
> code
> ( thrift compiler compile carbondata format files to java code) to build,
> then users don't need to do any thrift installation.
>
> +1 for new solution.
>
> Regards
> Liang
>
> QiangCai wrote
> > Hi
> >
> > Currently, There are two typical Thrift issues:
> >
> > 1.Users want to directly build Apache CarbonData, don’t need to install
> > Thrift in advance. For example:
> >
> > Julian Hyde-3’s feedback in IPMC mailing list: I was not able to build
> > (not your fault - I did not have thrift
> > installed and didn't have the time & patience to install it).
> >
> > 2.Need to fix Apache Jenkins CI issues, as below:
> >
> > [ERROR] Failed to execute goal
> > org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
> > (generate-thrift-java) on project carbondata-format: thrift did not exit
> > cleanly. Review output for more information. -> [Help 1]
> >
> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
> execute
> > goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
> > (generate-thrift-java) on project carbondata-format: thrift did not exit
> > cleanly. Review output for more information.
> >
> > For solving the above mentioned Thrift issues, i would like to propose
> one
> > solution: Directly use java code ( thrift compiler compile carbondata
> > format files to java code) to build, then users don't need to do any
> > thrift installation.
> >
> > please vote and comment :
> >
> > To continue use the current manual install method to build
> >
> > or
> >
> > To directly use java code which be generated by thrift compiler to build
>
>
>
>
>
> --
> View this message in context: http://apache-carbondata-
> mailing-list-archive.1130556.n5.nabble.com/please-vote-and-
> comment-remove-thrift-solution-tp2253p2254.html
> Sent from the Apache CarbonData Mailing List archive mailing list archive
> at Nabble.com.
>
Re: please vote and comment: remove thrift solution
Posted by Liang Chen <ch...@gmail.com>.
Hi
I prefer to the new solution for fixing thrift issues:Directly use java code
( thrift compiler compile carbondata format files to java code) to build,
then users don't need to do any thrift installation.
+1 for new solution.
Regards
Liang
QiangCai wrote
> Hi
>
> Currently, There are two typical Thrift issues:
>
> 1.Users want to directly build Apache CarbonData, don’t need to install
> Thrift in advance. For example:
>
> Julian Hyde-3’s feedback in IPMC mailing list: I was not able to build
> (not your fault - I did not have thrift
> installed and didn't have the time & patience to install it).
>
> 2.Need to fix Apache Jenkins CI issues, as below:
>
> [ERROR] Failed to execute goal
> org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
> (generate-thrift-java) on project carbondata-format: thrift did not exit
> cleanly. Review output for more information. -> [Help 1]
>
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
> (generate-thrift-java) on project carbondata-format: thrift did not exit
> cleanly. Review output for more information.
>
> For solving the above mentioned Thrift issues, i would like to propose one
> solution: Directly use java code ( thrift compiler compile carbondata
> format files to java code) to build, then users don't need to do any
> thrift installation.
>
> please vote and comment :
>
> To continue use the current manual install method to build
>
> or
>
> To directly use java code which be generated by thrift compiler to build
--
View this message in context: http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/please-vote-and-comment-remove-thrift-solution-tp2253p2254.html
Sent from the Apache CarbonData Mailing List archive mailing list archive at Nabble.com.
RE: please vote and comment: remove thrift solution
Posted by Jihong Ma <Ji...@huawei.com>.
+1.
I agree shipping the generated JAVA code has drawback, we should explore to publish it on Maven central repository for release, so that with the correct artifacts in place for the corresponding release in pom.xml, we are good.
Jihong
-----Original Message-----
From: Jacky Li [mailto:jacky.likun@qq.com]
Sent: Monday, October 24, 2016 5:48 AM
To: dev@carbondata.incubator.apache.org
Subject: Re: please vote and comment: remove thrift solution
I agree with Ravindra, this is not the best approach. But since this issue block integration with Apache CI, I think it makes sense to solve it quickly and do the best approach later.
Without CI automation, it is really a pain to manually trigger the CI for every PR.
So, +1
Regards,
Jacky
> 在 2016年10月24日，下午7:17，Jean-Baptiste Onofré <jb...@nanthrax.net> 写道：
>
> +1
>
> It makes sense to me.
>
> Regards
> JB
>
>
>
> On Oct 24, 2016, 13:03, at 13:03, Vimal Das Kammath <vi...@gmail.com> wrote:
>> Yes, I agree with Ravindra and Vishal.
>> Instead of the source code, we can have the jar published to
>> repository,
>> We can have a maven profile that depends on carbon-format as jar from
>> repository (this can be the default, for new developers to build
>> successfully)
>> However, We also should have a profile that compiles the thrift files
>> and
>> publishes the jar which can be used by CI and developer who wants to
>> modify
>> the .thrift files.
>>
>> Regards
>> Vimal
>>
>> On Mon, Oct 24, 2016 at 3:13 PM, Kumar Vishal
>> <ku...@gmail.com>
>> wrote:
>>
>>> In case of any updation in thrift we need to update the java files. I
>> think
>>> keeping the java file is not a good idea.
>>>
>>> -Regards
>>>
>>> Kumar Vishal
>>>
>>> On Oct 24, 2016 13:13, "caiqiang" <qi...@qq.com> wrote:
>>>
>>>> Hi
>>>>
>>>> Currently, There are two typical Thrift issues:
>>>>
>>>> 1.Users want to directly build Apache CarbonData, don’t need to
>> install
>>>> Thrift in advance. For example:
>>>>
>>>> Julian Hyde-3’s feedback in IPMC mailing list: I was not able to
>> build
>>>> (not your fault - I did not have thrift
>>>> installed and didn't have the time & patience to install it).
>>>>
>>>> 2.Need to fix Apache Jenkins CI issues, as below:
>>>>
>>>> [ERROR] Failed to execute goal org.apache.thrift.tools:maven-
>>> thrift-plugin:0.1.11:compile
>>>> (generate-thrift-java) on project carbondata-format: thrift did not
>> exit
>>>> cleanly. Review output for more information. -> [Help 1]
>>>>
>>>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>>> execute
>>>> goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
>>>> (generate-thrift-java) on project carbondata-format: thrift did not
>> exit
>>>> cleanly. Review output for more information.
>>>>
>>>> For solving the above mentioned Thrift issues, i would like to
>> propose
>>> one
>>>> solution: Directly use java code ( thrift compiler compile
>> carbondata
>>>> format files to java code) to build, then users don't need to do
>> any
>>>> thrift installation.
>>>>
>>>> please vote and comment :
>>>>
>>>> To continue use the current manual install method to build
>>>>
>>>> or
>>>>
>>>> To directly use java code which be generated by thrift compiler to
>> build
>>>
Re: please vote and comment: remove thrift solution
Posted by Jacky Li <ja...@qq.com>.
I agree with Ravindra, this is not the best approach. But since this issue block integration with Apache CI, I think it makes sense to solve it quickly and do the best approach later.
Without CI automation, it is really a pain to manually trigger the CI for every PR.
So, +1
Regards,
Jacky
> 在 2016年10月24日，下午7:17，Jean-Baptiste Onofré <jb...@nanthrax.net> 写道：
>
> +1
>
> It makes sense to me.
>
> Regards
> JB
>
>
>
> On Oct 24, 2016, 13:03, at 13:03, Vimal Das Kammath <vi...@gmail.com> wrote:
>> Yes, I agree with Ravindra and Vishal.
>> Instead of the source code, we can have the jar published to
>> repository,
>> We can have a maven profile that depends on carbon-format as jar from
>> repository (this can be the default, for new developers to build
>> successfully)
>> However, We also should have a profile that compiles the thrift files
>> and
>> publishes the jar which can be used by CI and developer who wants to
>> modify
>> the .thrift files.
>>
>> Regards
>> Vimal
>>
>> On Mon, Oct 24, 2016 at 3:13 PM, Kumar Vishal
>> <ku...@gmail.com>
>> wrote:
>>
>>> In case of any updation in thrift we need to update the java files. I
>> think
>>> keeping the java file is not a good idea.
>>>
>>> -Regards
>>>
>>> Kumar Vishal
>>>
>>> On Oct 24, 2016 13:13, "caiqiang" <qi...@qq.com> wrote:
>>>
>>>> Hi
>>>>
>>>> Currently, There are two typical Thrift issues:
>>>>
>>>> 1.Users want to directly build Apache CarbonData, don’t need to
>> install
>>>> Thrift in advance. For example:
>>>>
>>>> Julian Hyde-3’s feedback in IPMC mailing list: I was not able to
>> build
>>>> (not your fault - I did not have thrift
>>>> installed and didn't have the time & patience to install it).
>>>>
>>>> 2.Need to fix Apache Jenkins CI issues, as below:
>>>>
>>>> [ERROR] Failed to execute goal org.apache.thrift.tools:maven-
>>> thrift-plugin:0.1.11:compile
>>>> (generate-thrift-java) on project carbondata-format: thrift did not
>> exit
>>>> cleanly. Review output for more information. -> [Help 1]
>>>>
>>>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>>> execute
>>>> goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
>>>> (generate-thrift-java) on project carbondata-format: thrift did not
>> exit
>>>> cleanly. Review output for more information.
>>>>
>>>> For solving the above mentioned Thrift issues, i would like to
>> propose
>>> one
>>>> solution: Directly use java code ( thrift compiler compile
>> carbondata
>>>> format files to java code) to build, then users don't need to do
>> any
>>>> thrift installation.
>>>>
>>>> please vote and comment :
>>>>
>>>> To continue use the current manual install method to build
>>>>
>>>> or
>>>>
>>>> To directly use java code which be generated by thrift compiler to
>> build
>>>
Re: please vote and comment: remove thrift solution
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
+1
It makes sense to me.
Regards
JB
\u2063\u200b
On Oct 24, 2016, 13:03, at 13:03, Vimal Das Kammath <vi...@gmail.com> wrote:
>Yes, I agree with Ravindra and Vishal.
>Instead of the source code, we can have the jar published to
>repository,
>We can have a maven profile that depends on carbon-format as jar from
>repository (this can be the default, for new developers to build
>successfully)
>However, We also should have a profile that compiles the thrift files
>and
>publishes the jar which can be used by CI and developer who wants to
>modify
>the .thrift files.
>
>Regards
>Vimal
>
>On Mon, Oct 24, 2016 at 3:13 PM, Kumar Vishal
><ku...@gmail.com>
>wrote:
>
>> In case of any updation in thrift we need to update the java files. I
>think
>> keeping the java file is not a good idea.
>>
>> -Regards
>>
>> Kumar Vishal
>>
>> On Oct 24, 2016 13:13, "caiqiang" <qi...@qq.com> wrote:
>>
>> > Hi
>> >
>> > Currently, There are two typical Thrift issues:
>> >
>> > 1.Users want to directly build Apache CarbonData, don\u2019t need to
>install
>> > Thrift in advance. For example:
>> >
>> > Julian Hyde-3\u2019s feedback in IPMC mailing list: I was not able to
>build
>> > (not your fault - I did not have thrift
>> > installed and didn't have the time & patience to install it).
>> >
>> > 2.Need to fix Apache Jenkins CI issues, as below:
>> >
>> > [ERROR] Failed to execute goal org.apache.thrift.tools:maven-
>> thrift-plugin:0.1.11:compile
>> > (generate-thrift-java) on project carbondata-format: thrift did not
>exit
>> > cleanly. Review output for more information. -> [Help 1]
>> >
>> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>> execute
>> > goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
>> > (generate-thrift-java) on project carbondata-format: thrift did not
>exit
>> > cleanly. Review output for more information.
>> >
>> > For solving the above mentioned Thrift issues, i would like to
>propose
>> one
>> > solution: Directly use java code ( thrift compiler compile
>carbondata
>> > format files to java code) to build, then users don't need to do
>any
>> > thrift installation.
>> >
>> > please vote and comment :
>> >
>> > To continue use the current manual install method to build
>> >
>> > or
>> >
>> > To directly use java code which be generated by thrift compiler to
>build
>>
Re: please vote and comment: remove thrift solution
Posted by Vimal Das Kammath <vi...@gmail.com>.
Yes, I agree with Ravindra and Vishal.
Instead of the source code, we can have the jar published to repository,
We can have a maven profile that depends on carbon-format as jar from
repository (this can be the default, for new developers to build
successfully)
However, We also should have a profile that compiles the thrift files and
publishes the jar which can be used by CI and developer who wants to modify
the .thrift files.
Regards
Vimal
On Mon, Oct 24, 2016 at 3:13 PM, Kumar Vishal <ku...@gmail.com>
wrote:
> In case of any updation in thrift we need to update the java files. I think
> keeping the java file is not a good idea.
>
> -Regards
>
> Kumar Vishal
>
> On Oct 24, 2016 13:13, "caiqiang" <qi...@qq.com> wrote:
>
> > Hi
> >
> > Currently, There are two typical Thrift issues:
> >
> > 1.Users want to directly build Apache CarbonData, don’t need to install
> > Thrift in advance. For example:
> >
> > Julian Hyde-3’s feedback in IPMC mailing list: I was not able to build
> > (not your fault - I did not have thrift
> > installed and didn't have the time & patience to install it).
> >
> > 2.Need to fix Apache Jenkins CI issues, as below:
> >
> > [ERROR] Failed to execute goal org.apache.thrift.tools:maven-
> thrift-plugin:0.1.11:compile
> > (generate-thrift-java) on project carbondata-format: thrift did not exit
> > cleanly. Review output for more information. -> [Help 1]
> >
> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
> execute
> > goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
> > (generate-thrift-java) on project carbondata-format: thrift did not exit
> > cleanly. Review output for more information.
> >
> > For solving the above mentioned Thrift issues, i would like to propose
> one
> > solution: Directly use java code ( thrift compiler compile carbondata
> > format files to java code) to build, then users don't need to do any
> > thrift installation.
> >
> > please vote and comment :
> >
> > To continue use the current manual install method to build
> >
> > or
> >
> > To directly use java code which be generated by thrift compiler to build
>
Re: please vote and comment: remove thrift solution
Posted by Kumar Vishal <ku...@gmail.com>.
In case of any updation in thrift we need to update the java files. I think
keeping the java file is not a good idea.
-Regards
Kumar Vishal
On Oct 24, 2016 13:13, "caiqiang" <qi...@qq.com> wrote:
> Hi
>
> Currently, There are two typical Thrift issues:
>
> 1.Users want to directly build Apache CarbonData, don’t need to install
> Thrift in advance. For example:
>
> Julian Hyde-3’s feedback in IPMC mailing list: I was not able to build
> (not your fault - I did not have thrift
> installed and didn't have the time & patience to install it).
>
> 2.Need to fix Apache Jenkins CI issues, as below:
>
> [ERROR] Failed to execute goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
> (generate-thrift-java) on project carbondata-format: thrift did not exit
> cleanly. Review output for more information. -> [Help 1]
>
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile
> (generate-thrift-java) on project carbondata-format: thrift did not exit
> cleanly. Review output for more information.
>
> For solving the above mentioned Thrift issues, i would like to propose one
> solution: Directly use java code ( thrift compiler compile carbondata
> format files to java code) to build, then users don't need to do any
> thrift installation.
>
> please vote and comment :
>
> To continue use the current manual install method to build
>
> or
>
> To directly use java code which be generated by thrift compiler to build