You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by be...@apache.org on 2009/01/04 13:24:34 UTC
svn commit: r731237 -
/maven/plugin-tools/trunk/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java
Author: bentmann
Date: Sun Jan 4 04:24:34 2009
New Revision: 731237
URL: http://svn.apache.org/viewvc?rev=731237&view=rev
Log:
[MPLUGIN-141] Output warning for deprecated component expressions
Modified:
maven/plugin-tools/trunk/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java
Modified: maven/plugin-tools/trunk/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java?rev=731237&r1=731236&r2=731237&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java Sun Jan 4 04:24:34 2009
@@ -510,7 +510,18 @@
pd.setAlias( alias );
}
- pd.setExpression( parameter.getNamedParameter( JavaMojoAnnotation.PARAMETER_EXPRESSION ) );
+ String expression = parameter.getNamedParameter( JavaMojoAnnotation.PARAMETER_EXPRESSION );
+ pd.setExpression( expression );
+
+ if ( StringUtils.isNotEmpty( expression ) && expression.startsWith( "${component." ) )
+ {
+ getLogger().warn( javaClass.getFullyQualifiedName() + "#" + field.getName() + ":" );
+ getLogger().warn( " The syntax" );
+ getLogger().warn( " @parameter expression=\"${component.<role>#<roleHint>}\"" );
+ getLogger().warn( " is deprecated, please use" );
+ getLogger().warn( " @component role=\"<role>\" roleHint=\"<roleHint>\"" );
+ getLogger().warn( " instead." );
+ }
if ( "${reports}".equals( pd.getExpression() ) )
{