You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/12/01 13:43:04 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #5038: Proxy autodetection + autoconfiguration for Maven.
sdedic opened a new pull request, #5038:
URL: https://github.com/apache/netbeans/pull/5038
Similar to #5006 but for Maven. For "priming build" and maven online invocations, the proxy is checked first. If mismatch is found, the IDE asks the user (the default setting) other actions can be: ignore, auto-update maven settings.xml or override on-the-fly.
The override is done by generating a copy of the `~/.m2/settings.xml` with relevant parts changed/added, maven is then invoked with `--settings` option. Generated files are put into `$nbuserdir/var/cache`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
sdedic commented on code in PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#discussion_r1041523000
##########
java/maven/src/org/netbeans/modules/maven/problems/SanityBuildAction.java:
##########
@@ -97,6 +107,21 @@ public void run() {
String label = build_label(nbproject.getProjectDirectory().getNameExt());
config.setExecutionName(label);
config.setTaskDisplayName(label);
+
+ MavenProxySupport mps = nbproject.getLookup().lookup(MavenProxySupport.class);
+ if (mps != null) {
+ ProxyResult res;
Review Comment:
fixed in 5d31b280c9d8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
sdedic commented on code in PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#discussion_r1041523150
##########
java/maven/src/org/netbeans/modules/maven/options/NetworkProxySettings.java:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.maven.options;
+
+import org.netbeans.modules.maven.api.execute.RunUtils;
+import org.openide.util.NbBundle;
+
+/**
+ *
+ * @author sdedic
+ */
+@NbBundle.Messages({
+ "PROXY_IGNORE=Do not check",
+ "PROXY_NOTICE=Display Mismatch Notice",
+ "PROXY_UPDATE=Update User Properties",
+ "PROXY_ASK=Ask Before Execution",
+ "PROXY_OVERRIDE=Override on execution",
+})
+public enum NetworkProxySettings {
+ /**
+ * Do not verify proxy settings.
+ */
+ IGNORE,
+ /**
+ * Display a notice that proxy settings mismatch.
+ */
+ NOTICE,
+ /**
+ * Update user's gradle.properties file.
+ */
+ UPDATE,
+ /**
+ * Ask the user for confirmation.
+ */
+ ASK,
+ /**
+ * Automatically override on execution, but do not change gradle.properties.
+ */
+ OVERRIDE;
+
+ public String toString() {
+ switch (this) {
Review Comment:
fixed in 5d31b280c9d8 + 1126d7540e8a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#discussion_r1041377326
##########
java/maven/src/org/netbeans/modules/maven/options/SettingsPanel.java:
##########
@@ -826,7 +850,7 @@ public void valueChanged(javax.swing.event.ListSelectionEvent evt) {
.addComponent(lblCategory)
.addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED)
.addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
- .addComponent(pnlCards, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE)
+ .addComponent(pnlCards, javax.swing.GroupLayout.DEFAULT_SIZE, 547, Short.MAX_VALUE)
Review Comment:
Can you switch this back to `DEFAULT_SIZE`? This would set the component to a fixed size and layout managers won't resize it.
When I open the options now i see scroll bars even though everything would fit into the window.
To achieve this its often possible to open the panel in question via double click on the navigator. Then reduce the size till it snaps to default size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#issuecomment-1409852395
I saw this dialog the first time today:
What is missing IMHO is a guide how to silence this. I had to come here to realize, that he solution is as easy as going to maven settings and setting the proxy selection to "Do not check".
Spelling this out for me ("Go to Options -> Java -> Maven -> Execution -> Network proxy to change the default action") would have helped me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbownik commented on a diff in pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
lbownik commented on code in PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#discussion_r1037968907
##########
java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java:
##########
@@ -225,6 +236,49 @@ public void run() {
int executionresult = -10;
final InputOutput ioput = getInputOutput();
+ MavenProxySupport mps = clonedConfig.getProject().getLookup().lookup(MavenProxySupport.class);
+ if (mps != null) {
+ MavenProxySupport.ProxyResult res;
Review Comment:
how about moving it to line 244 where it can be instanlty initialized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbownik commented on a diff in pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
lbownik commented on code in PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#discussion_r1037974289
##########
java/maven/src/org/netbeans/modules/maven/options/NetworkProxySettings.java:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.maven.options;
+
+import org.netbeans.modules.maven.api.execute.RunUtils;
+import org.openide.util.NbBundle;
+
+/**
+ *
+ * @author sdedic
+ */
+@NbBundle.Messages({
+ "PROXY_IGNORE=Do not check",
+ "PROXY_NOTICE=Display Mismatch Notice",
+ "PROXY_UPDATE=Update User Properties",
+ "PROXY_ASK=Ask Before Execution",
+ "PROXY_OVERRIDE=Override on execution",
+})
+public enum NetworkProxySettings {
+ /**
+ * Do not verify proxy settings.
+ */
+ IGNORE,
+ /**
+ * Display a notice that proxy settings mismatch.
+ */
+ NOTICE,
+ /**
+ * Update user's gradle.properties file.
+ */
+ UPDATE,
+ /**
+ * Ask the user for confirmation.
+ */
+ ASK,
+ /**
+ * Automatically override on execution, but do not change gradle.properties.
+ */
+ OVERRIDE;
+
+ public String toString() {
+ switch (this) {
Review Comment:
wouldnt it be more elegant to introduce a proviate "name" or "str" field, initialize it properly it via constructor and then simply return it from toString()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#issuecomment-1340091917
> maybe its fine. Its just that I usually wouldn't expect NW options between command line flags and maven goal definitions. If it should remain where it is right now, I would try to make the combo box the same width as the text field.
>
Kept order, made textfield + combo same size, resizable, aligned -- 1126d7540e8a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
sdedic merged PR #5038:
URL: https://github.com/apache/netbeans/pull/5038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#issuecomment-1339975174
> > The position right now is right between global exec options and global custom goals. It might look better if its moved one row up which would leave the other settings grouped together.
>
> You mean reorder to:
>
> * network proxy
>
> * global exec options
>
> * the rest ?
>
>
> If so then I'd separate the exec + network options (that affect the execution of maven) from the rest that affects behaviour of the tool
maybe its fine. Its just that I usually wouldn't expect NW options between command line flags and maven goal definitions. If it should remain where it is right now, I would try to make the combo box the same width as the text field.
This panel might need a UI pass anyway, e.g maybe it would make sense to move everything what is below "edit global custom goal defs" to the appearance category which is almost empty ATM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#issuecomment-1339957278
> The position right now is right between global exec options and global custom goals. It might look better if its moved one row up which would leave the other settings grouped together.
You mean reorder to:
- network proxy
- global exec options
- the rest ?
If so then I'd separate the exec + network options (that affect the execution of maven) from the rest that affects behaviour of the tool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbownik commented on a diff in pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
lbownik commented on code in PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#discussion_r1037977031
##########
java/maven/src/org/netbeans/modules/maven/problems/SanityBuildAction.java:
##########
@@ -97,6 +107,21 @@ public void run() {
String label = build_label(nbproject.getProjectDirectory().getNameExt());
config.setExecutionName(label);
config.setTaskDisplayName(label);
+
+ MavenProxySupport mps = nbproject.getLookup().lookup(MavenProxySupport.class);
+ if (mps != null) {
+ ProxyResult res;
Review Comment:
this variable seems to be unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#issuecomment-1340131551
looks much better to me now + can confirm that the combo box is working now
one more thing if you have the patience:
- double click on all cards starting with the children on the navigator and shrink the height till it snaps to default size.
- once done do the same for the main panel
this will remove the scrollbar since everything will be set to minimum size and the layout manager can do the rest.
here a diff if you want to apply it directly instead:
```diff
diff --git a/java/maven/src/org/netbeans/modules/maven/options/SettingsPanel.form b/java/maven/src/org/netbeans/modules/maven/options/SettingsPanel.form
index 595c94e..151e2a9 100644
--- a/java/maven/src/org/netbeans/modules/maven/options/SettingsPanel.form
+++ b/java/maven/src/org/netbeans/modules/maven/options/SettingsPanel.form
@@ -216,7 +216,7 @@
</Group>
<EmptySpace max="-2" attributes="0"/>
<Component id="jLabel3" min="-2" pref="44" max="-2" attributes="0"/>
- <EmptySpace pref="379" max="32767" attributes="0"/>
+ <EmptySpace max="32767" attributes="0"/>
</Group>
</Group>
</DimensionLayout>
@@ -322,7 +322,7 @@
<Component id="cbDisableIndex" min="-2" max="-2" attributes="0"/>
<EmptySpace max="-2" attributes="0"/>
<Component id="jLabel5" min="-2" max="-2" attributes="0"/>
- <EmptySpace pref="450" max="32767" attributes="0"/>
+ <EmptySpace max="32767" attributes="0"/>
</Group>
</Group>
</DimensionLayout>
@@ -422,7 +422,7 @@
<Component id="txtDirectory" alignment="3" min="-2" max="-2" attributes="0"/>
<Component id="btnDirectory" alignment="3" min="-2" max="-2" attributes="0"/>
</Group>
- <EmptySpace pref="332" max="32767" attributes="0"/>
+ <EmptySpace max="32767" attributes="0"/>
</Group>
</Group>
</DimensionLayout>
diff --git a/java/maven/src/org/netbeans/modules/maven/options/SettingsPanel.java b/java/maven/src/org/netbeans/modules/maven/options/SettingsPanel.java
index 187de3b..b960bfc 100644
--- a/java/maven/src/org/netbeans/modules/maven/options/SettingsPanel.java
+++ b/java/maven/src/org/netbeans/modules/maven/options/SettingsPanel.java
@@ -525,7 +525,7 @@
.addComponent(comSource, javax.swing.GroupLayout.PREFERRED_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.PREFERRED_SIZE))
.addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED)
.addComponent(jLabel3, javax.swing.GroupLayout.PREFERRED_SIZE, 44, javax.swing.GroupLayout.PREFERRED_SIZE)
- .addContainerGap(379, Short.MAX_VALUE))
+ .addContainerGap(javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE))
);
pnlCards.add(pnlDependencies, "dependencies");
@@ -585,7 +585,7 @@
.addComponent(cbDisableIndex)
.addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED)
.addComponent(jLabel5)
- .addContainerGap(450, Short.MAX_VALUE))
+ .addContainerGap(javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE))
);
pnlCards.add(pnlIndex, "index");
@@ -641,7 +641,7 @@
.addComponent(lblDirectory)
.addComponent(txtDirectory, javax.swing.GroupLayout.PREFERRED_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.PREFERRED_SIZE)
.addComponent(btnDirectory))
- .addContainerGap(332, Short.MAX_VALUE))
+ .addContainerGap(javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE))
);
pnlCards.add(plnExperimental, "experimental");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
sdedic commented on code in PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#discussion_r1038035240
##########
java/maven/src/org/netbeans/modules/maven/problems/SanityBuildAction.java:
##########
@@ -97,6 +107,21 @@ public void run() {
String label = build_label(nbproject.getProjectDirectory().getNameExt());
config.setExecutionName(label);
config.setTaskDisplayName(label);
+
+ MavenProxySupport mps = nbproject.getLookup().lookup(MavenProxySupport.class);
+ if (mps != null) {
+ ProxyResult res;
Review Comment:
Hm, I'll better check the behaviour with 'cancel' in the dialog; thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
sdedic commented on code in PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#discussion_r1041413758
##########
java/maven/src/org/netbeans/modules/maven/options/SettingsPanel.java:
##########
@@ -826,7 +850,7 @@ public void valueChanged(javax.swing.event.ListSelectionEvent evt) {
.addComponent(lblCategory)
.addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED)
.addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
- .addComponent(pnlCards, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE)
+ .addComponent(pnlCards, javax.swing.GroupLayout.DEFAULT_SIZE, 547, Short.MAX_VALUE)
Review Comment:
argh ... stupid copy / cleanup error before commit: missing assignment. Thanks for catching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #5038: Proxy autodetection + autoconfiguration for Maven.
Posted by GitBox <gi...@apache.org>.
sdedic commented on code in PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#discussion_r1041522866
##########
java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java:
##########
@@ -225,6 +236,49 @@ public void run() {
int executionresult = -10;
final InputOutput ioput = getInputOutput();
+ MavenProxySupport mps = clonedConfig.getProject().getLookup().lookup(MavenProxySupport.class);
+ if (mps != null) {
+ MavenProxySupport.ProxyResult res;
Review Comment:
fixed in 5d31b280c9d8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists