You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Greg Malewicz (JIRA)" <ji...@apache.org> on 2012/09/22 00:12:07 UTC
[jira] [Created] (GIRAPH-336) style violations in
giraph-formats-contrib
Greg Malewicz created GIRAPH-336:
------------------------------------
Summary: style violations in giraph-formats-contrib
Key: GIRAPH-336
URL: https://issues.apache.org/jira/browse/GIRAPH-336
Project: Giraph
Issue Type: Improvement
Reporter: Greg Malewicz
A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464837#comment-13464837 ]
Brian Femiano commented on GIRAPH-336:
--------------------------------------
Ok I see what happened. The patch from Giraph-343 moved the location of these files, which conflicted with my patch.
I'll make the review changes and merge my style check fixes into the new code locations.
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.2.0
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Fix For: 0.2.0
>
> Attachments: GIRAPH-336.patch, style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461906#comment-13461906 ]
Brian Femiano commented on GIRAPH-336:
--------------------------------------
The build was also broken somehow so I assigned to myself. I'll fix these for the same patch.
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Attachments: style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461886#comment-13461886 ]
Brian Femiano commented on GIRAPH-336:
--------------------------------------
Looks like they're all in the newer HCatalog and Hive Runner files.
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Attachments: style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464473#comment-13464473 ]
Avery Ching commented on GIRAPH-336:
------------------------------------
Thanks for taking this on! Here are my comments [~bfem].
https://reviews.apache.org/r/7310/
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.2.0
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Fix For: 0.2.0
>
> Attachments: GIRAPH-336.patch, style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462957#comment-13462957 ]
Nitay Joffe commented on GIRAPH-336:
------------------------------------
Brian see GIRAPH-343
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Attachments: style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461985#comment-13461985 ]
Brian Femiano commented on GIRAPH-336:
--------------------------------------
Opening a new ticket since I can't get the hcatalog maven dependency to load.
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Attachments: style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465122#comment-13465122 ]
Brian Femiano commented on GIRAPH-336:
--------------------------------------
Patch available in GIRAPH-350 that fixes these review comments.
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Affects Versions: 0.2.0
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Fix For: 0.2.0
>
> Attachments: GIRAPH-336.patch, style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462000#comment-13462000 ]
Brian Femiano commented on GIRAPH-336:
--------------------------------------
Gotcha. The build does not run with the profile though.
I'm cleaning up the Accumulo/HBase formats to account for the updated checkstyle requirements.
I'll updated the HCatalog files while I'm at it.
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Attachments: style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462001#comment-13462001 ]
Nitay Joffe commented on GIRAPH-336:
------------------------------------
Correct, that is by design. It currently works only if you get an hcatalog jar and mvn install-file it yourself. It is a workaround until https://issues.apache.org/jira/browse/HCATALOG-132 goes in, which looks like will happen soon.
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Attachments: style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Greg Malewicz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Malewicz updated GIRAPH-336:
---------------------------------
Attachment: style_violations.txt
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Attachments: style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461989#comment-13461989 ]
Nitay Joffe commented on GIRAPH-336:
------------------------------------
Brian the build should not be broken. HCatalog is not in maven yet, that is why I added the profile to make it optional. See GIRAPH-93
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Attachments: style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Femiano reassigned GIRAPH-336:
------------------------------------
Assignee: Brian Femiano
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Attachments: style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462964#comment-13462964 ]
Brian Femiano commented on GIRAPH-336:
--------------------------------------
K.
Once the GIRAPH-343 is approved and committed I'll continue the style check updates in the new package.
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Attachments: style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461888#comment-13461888 ]
Nitay Joffe commented on GIRAPH-336:
------------------------------------
Yeah you can assign to me if you like I'll take a look when I have a chance.
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Attachments: style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462491#comment-13462491 ]
Avery Ching commented on GIRAPH-336:
------------------------------------
Thanks Brian.
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Attachments: style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464436#comment-13464436 ]
Brian Femiano commented on GIRAPH-336:
--------------------------------------
Added patch diffed from trunk. Passes all default profile tests.
checkstyle requirement for all listed classes are passing in IntellJ.
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Attachments: GIRAPH-336.patch, style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Femiano updated GIRAPH-336:
---------------------------------
Attachment: GIRAPH-336.patch
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Assignee: Brian Femiano
> Attachments: GIRAPH-336.patch, style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-336) style violations in
giraph-formats-contrib
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460887#comment-13460887 ]
Avery Ching commented on GIRAPH-336:
------------------------------------
Thanks for reporting this Greg. Maybe either Nitay or Brian can take a look?
> style violations in giraph-formats-contrib
> ------------------------------------------
>
> Key: GIRAPH-336
> URL: https://issues.apache.org/jira/browse/GIRAPH-336
> Project: Giraph
> Issue Type: Improvement
> Reporter: Greg Malewicz
> Attachments: style_violations.txt
>
>
> A list of 590 style violations in giraph-formats-contrib as reported by "mvn install" is attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira