You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by WireBaron <gi...@git.apache.org> on 2017/07/12 23:32:26 UTC

[GitHub] geode pull request #629: GEODE-2997: New flow getAll/putAll

GitHub user WireBaron opened a pull request:

    https://github.com/apache/geode/pull/629

    GEODE-2997: New flow getAll/putAll

    Changed get response to indicate if LookupFailure was a missing key or key with null value, added test
    Added GetAllRequestOperationHandler and unit test
    Added PutAllRequestOperationHandler and unit test
    Added an integration test covering the putAll and getAll operations
    Removed serverInternal and retriable fields from ErrorResponse, replaced with errorCode field
    
    Signed-off-by: Brian Rowe <br...@pivotal.io>
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [x] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WireBaron/geode feature/GEODE-2997

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/629.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #629
    
----
commit 510d579788abdd04e49b6ee7748fe0953e972e99
Author: Alexander Murmann <am...@pivotal.io>
Date:   2017-07-06T00:36:20Z

    GEODE-2997: New flow getAll/putAll
    
    Changed get response to indicate if LookupFailure was a missing key or key with null value, added test
    Added GetAllRequestOperationHandler and unit test
    Added PutAllRequestOperationHandler and unit test
    Added an integration test covering the putAll and getAll operations
    Removed serverInternal and retriable fields from ErrorResponse, replaced with errorCode field
    
    Signed-off-by: Brian Rowe <br...@pivotal.io>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #629: GEODE-2997: New flow getAll/putAll

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/629


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---