You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "dragon-zhang (via GitHub)" <gi...@apache.org> on 2023/09/05 08:33:16 UTC
[GitHub] [shenyu] dragon-zhang opened a new pull request, #5119: [ISSUE #4687] part1: RewritePlugin supports percentage
dragon-zhang opened a new pull request, #5119:
URL: https://github.com/apache/shenyu/pull/5119
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] moremind merged pull request #5119: [ISSUE #4687] part1: RewritePlugin supports percentage
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind merged PR #5119:
URL: https://github.com/apache/shenyu/pull/5119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] moremind commented on pull request #5119: [ISSUE #4687] part1: RewritePlugin supports percentage
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on PR #5119:
URL: https://github.com/apache/shenyu/pull/5119#issuecomment-1707523986
may add sql for `percentage` field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang closed pull request #5119: [ISSUE #4687] part1: RewritePlugin supports percentage
Posted by "dragon-zhang (via GitHub)" <gi...@apache.org>.
dragon-zhang closed pull request #5119: [ISSUE #4687] part1: RewritePlugin supports percentage
URL: https://github.com/apache/shenyu/pull/5119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang commented on pull request #5119: [ISSUE #4687] part1: RewritePlugin supports percentage
Posted by "dragon-zhang (via GitHub)" <gi...@apache.org>.
dragon-zhang commented on PR #5119:
URL: https://github.com/apache/shenyu/pull/5119#issuecomment-1709950121
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #5119: [ISSUE #4687] part1: RewritePlugin supports percentage
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5119:
URL: https://github.com/apache/shenyu/pull/5119#issuecomment-1721264482
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5119?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5119](https://app.codecov.io/gh/apache/shenyu/pull/5119?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0752366) into [master](https://app.codecov.io/gh/apache/shenyu/commit/787fef04c4db4f82950a7ffa37ecb1c4aff24a21?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (787fef0) will **increase** coverage by `0.06%`.
> The diff coverage is `33.33%`.
```diff
@@ Coverage Diff @@
## master #5119 +/- ##
============================================
+ Coverage 60.80% 60.86% +0.06%
- Complexity 8462 8469 +7
============================================
Files 1242 1242
Lines 37433 37438 +5
Branches 3532 3533 +1
============================================
+ Hits 22762 22788 +26
+ Misses 12722 12692 -30
- Partials 1949 1958 +9
```
| [Files Changed](https://app.codecov.io/gh/apache/shenyu/pull/5119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../shenyu/common/dto/convert/rule/RewriteHandle.java](https://app.codecov.io/gh/apache/shenyu/pull/5119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL1Jld3JpdGVIYW5kbGUuamF2YQ==) | `50.00% <0.00%> (-10.00%)` | :arrow_down: |
| [...rg/apache/shenyu/plugin/rewrite/RewritePlugin.java](https://app.codecov.io/gh/apache/shenyu/pull/5119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vcmV3cml0ZS9SZXdyaXRlUGx1Z2luLmphdmE=) | `70.00% <66.66%> (-2.23%)` | :arrow_down: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5119/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org