[GitHub] [cordova-node-xcode] Panajev commented on pull request #87: Add support for On Demand Resources tags on iOS

[GitBox <gi...@apache.org>]

Panajev commented on pull request #87:
URL: https://github.com/apache/cordova-node-xcode/pull/87#issuecomment-643453442


   Hello Chris,
   
   Thanks for your reply, I will be talking to the devs to update this PR with some additional comments.
   
   As we were discussing earlier in the thread, we were in need of adding ODR asset tags to our whitelabelled application and each “variant” may need a sizeable variety of different On Demand Resources that would not be feasible to add manually.
   
   This set of changes adds features to add and remove On Demand Resources tags you the Xcode Project allowing you to also support some variants with and some without ODR support without leaving lots of cruft behind. We have extended the sample project a bit, but if useful we can expand more on it. What would you suggest to add to make it compatible with the upstream project?
   
   Sent from my iPhone
   
   > On 12 Jun 2020, at 19:55, Chris Brody <no...@github.com> wrote:
   > 
   > 
   > Maintainers have been pretty overloaded with major release items, many of us have limited time due to day jobs as well. Anything that can help us better understand and test this functionality would be much appreciated.
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org