You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "rtyler (via GitHub)" <gi...@apache.org> on 2025/07/09 15:00:09 UTC

[PR] Bump the MSRV due to transitive dependencies [datafusion]

rtyler opened a new pull request, #16728:
URL: https://github.com/apache/datafusion/pull/16728

   datafusion-cli depends on aws-config which has some transitive dependencies which require 1.85. This was a dependabot upgrade in 8366d6e155
   
   16:18:43  error: rustc 1.83.0 is not supported by the following packages:
   
   16:18:43    aws-sdk-sso@1.74.0 requires rustc 1.85.0
   
   16:18:43    aws-sdk-ssooidc@1.75.0 requires rustc 1.85.0
   
   16:18:43    aws-sdk-sts@1.76.0 requires rustc 1.85.0
   
   16:18:43  Either upgrade rustc or select compatible dependency versions with
   
   ```16:18:43  error: rustc 1.83.0 is not supported by the following packages:
   
   16:18:43    aws-sdk-sso@1.74.0 requires rustc 1.85.0
   16:18:43    aws-sdk-ssooidc@1.75.0 requires rustc 1.85.0
   16:18:43    aws-sdk-sts@1.76.0 requires rustc 1.85.0
   ```
   
   
   The AWS SDK for Rust team takes a pretty lenient approach with MSRV upgrades and doesn't really treat them as breaking which is why aws-config
   
   
   We could probably take this or bump back down to aws-config `=1.8.0`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Bump the MSRV due to transitive dependencies [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #16728:
URL: https://github.com/apache/datafusion/pull/16728


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Bump the MSRV due to transitive dependencies [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16728:
URL: https://github.com/apache/datafusion/pull/16728#issuecomment-3054126138

   Thanks @comphead and @rtyler 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Bump the MSRV to `1.85.1` due to transitive dependencies (`aws-sdk`) [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16728:
URL: https://github.com/apache/datafusion/pull/16728#issuecomment-3097875684

   I hit this during the delta-rs upgrade, so I made a PR proposing a note in the upgrade guide: 
   - https://github.com/apache/datafusion/pull/16845


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Bump the MSRV due to transitive dependencies [datafusion]

Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #16728:
URL: https://github.com/apache/datafusion/pull/16728#discussion_r2195336276


##########
Cargo.toml:
##########
@@ -75,7 +75,7 @@ license = "Apache-2.0"
 readme = "README.md"
 repository = "https://github.com/apache/datafusion"
 # Define Minimum Supported Rust Version (MSRV)
-rust-version = "1.82.0"
+rust-version = "1.85.0"

Review Comment:
   ```suggestion
   rust-version = "1.85.1"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org