You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2014/03/21 17:55:17 UTC
Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1737
https://issues.apache.org/jira/browse/OOZIE-1737
Repository: oozie-git
Description
-------
User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
Option can be.
* Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
* Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
offset.
* End: Server will streaming logs till specified end date. User can provide a valid date or offset.
* Loglevel : Multiple log levels separated by "|" can be specified.
* Text: String to search in logs.
* Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
matched.
* Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
calculated to.
In addition to this
1. System setting to control log streaming duration.
2. Added a option to show log streaming status.
A label on UI will show if log streaming is in progress, completed or erred.
3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
4. End the execution when data is date is reached.
earlier started date and end date is only used to load logs files.
......
Diffs
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 3c780dd
client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 0466ffe
core/src/main/java/org/apache/oozie/BundleEngine.java ce7c9c4
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 315a330
core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 2ef351e
core/src/main/java/org/apache/oozie/util/LogUserParam.java e69de29
core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
core/src/main/resources/oozie-default.xml 34362aa
core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
core/src/test/java/org/apache/oozie/service/TestLogStreamingParam.java e69de29
core/src/test/resources/userParamTestlog.log e69de29
docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
webapp/src/main/webapp/oozie-console.js 0b6cedf
Diff: https://reviews.apache.org/r/19520/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/#review38146
-----------------------------------------------------------
One concern I have is that these changes are adding more restrictions on how the user can configure log4j, right? We've seen pushback from users on the current set of restrictions (e.g. log file rolls every hour, using OozieRollingPolicy only, etc). Also, we should document the new restrictions if we go forward with them; though ideally, we can maybe make them less restrictive instead?
core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java
<https://reviews.apache.org/r/19520/#comment70113>
The exact same code is re-used again later in XLogStreamer; can we make a method somewhere instead?
- Robert Kanter
On March 21, 2014, 4:55 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19520/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 4:55 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1737
> https://issues.apache.org/jira/browse/OOZIE-1737
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
> Option can be.
> * Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
> * Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
> offset.
> * End: Server will streaming logs till specified end date. User can provide a valid date or offset.
> * Loglevel : Multiple log levels separated by "|" can be specified.
> * Text: String to search in logs.
> * Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
> matched.
> * Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
> calculated to.
>
>
> In addition to this
> 1. System setting to control log streaming duration.
> 2. Added a option to show log streaming status.
> A label on UI will show if log streaming is in progress, completed or erred.
> 3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
> 4. End the execution when data is date is reached.
> earlier started date and end date is only used to load logs files.
> ......
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 3c780dd
> client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 0466ffe
> core/src/main/java/org/apache/oozie/BundleEngine.java ce7c9c4
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 315a330
> core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
> core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
> core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 2ef351e
> core/src/main/java/org/apache/oozie/util/LogUserParam.java e69de29
> core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
> core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
> core/src/main/resources/oozie-default.xml 34362aa
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
> core/src/test/java/org/apache/oozie/service/TestLogStreamingParam.java e69de29
> core/src/test/resources/userParamTestlog.log e69de29
> docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
> webapp/src/main/webapp/oozie-console.js 0b6cedf
>
> Diff: https://reviews.apache.org/r/19520/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/#review38183
-----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/19520/#comment70168>
RestConstants.LOG_STREAMING_PARAMETER > RestConstants.LOG_FILTER_OPTION. Can you make the option -logfilter instead of -param and refer it as log filter everywhere. Option is used with job command and -param is very generic and does not clarify what it applies to.
Command line help should be more informative. List out the options of the -logfilter and usage. Refer to FILTER_OPTION in OozieCLI
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/19520/#comment70169>
formatting
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java
<https://reviews.apache.org/r/19520/#comment70170>
LOG_FILTER ="logfilter"
core/src/main/java/org/apache/oozie/BundleEngine.java
<https://reviews.apache.org/r/19520/#comment70173>
LogUserParam -> LogFilter
core/src/main/java/org/apache/oozie/BundleEngine.java
<https://reviews.apache.org/r/19520/#comment70177>
Add this as isTerminalStatus() to BundleJobBean. Can copy from CoordinatorJobBean
core/src/main/java/org/apache/oozie/BundleEngine.java
<https://reviews.apache.org/r/19520/#comment70176>
Keep a buffer of two minutes to pick up log statements after db update command to update last modified time was done.
core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/19520/#comment70178>
buffer of 2 mins
core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/19520/#comment70182>
Remove the commented line
core/src/main/java/org/apache/oozie/DagEngine.java
<https://reviews.apache.org/r/19520/#comment70183>
startTime variable is not used and can be removed. job.getCreatedTime() can directly be passed as before
core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java
<https://reviews.apache.org/r/19520/#comment70184>
Can you add a toString() method to the filter class and print details with that instead of doing it here?
core/src/main/java/org/apache/oozie/util/LogUserParam.java
<https://reviews.apache.org/r/19520/#comment70186>
Can we merge this class and XLogStreamer.Filter into one LogFilter class? It also has log levels, etc
core/src/main/java/org/apache/oozie/util/LogUserParam.java
<https://reviews.apache.org/r/19520/#comment70187>
Don't think this is good. Action ids will have @. There will be lot of -, [, ], etc in log statements.
May be we can just avoid wildcard (*) for now or not put any restriction as we can put limit on the max time range scanned now.
core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java
<https://reviews.apache.org/r/19520/#comment70208>
DateFormat is not thread safe. Either use threadlocal or use local variable
core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java
<https://reviews.apache.org/r/19520/#comment70209>
parseException
core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java
<https://reviews.apache.org/r/19520/#comment70212>
Please handle all this logic of loglimit and enddate in filter.matches() itself.
core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/19520/#comment70213>
formatting
core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/19520/#comment70224>
Can we move the logic of calculating start time and end time to LogFilter class itself
getLogScanStartTime(String jobStartTime, String jobEndTime)
getLogScanEndTime(String jobStartTime, String jobEndTime)
All the logic for filtering should only be in Filter class. They should not spill into XLogStreamer
core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/19520/#comment70238>
We need to do this only for bundle or coord job (with no actions). If they give a list of actions it is better to do a longer time range in one scan for all the actions.
core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/19520/#comment70239>
max.log.scan.duration
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/19520/#comment70242>
Filtering the server logs with logfilter options
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/19520/#comment70240>
make log streaming
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/19520/#comment70276>
Explain what offset for start and end do. Also tell what is the default when not specified. Give short examples here itself. i.e something like For eg: start=2013-01-01T05:00Z or start=1h or start=20m
Saw most of this is in conditions and usage. Better to merge them here as much as possible so that they are closer to the context.
I also see lot of split lines in the bulleted list. Did you check the html page generated. It will screw up bullets if the whole text is not in the same lien
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/19520/#comment70277>
Provide all options
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/19520/#comment70261>
Can we call this numlines instead of limit?
patten -> pattern. Can you run your patch through a spell checker?
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/19520/#comment70278>
Prints debug information on the log files, time ranges and patterns being searched for. Can be used to debug if expected logs are not shown with the filter options provided.
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/19520/#comment70281>
Can remove this.
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/19520/#comment70274>
Can you combine text and missing example. i.e "Missing" in last 1 hr.
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/19520/#comment70275>
Believe length and limit are same. 1st example has length. This example can be removed
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/19520/#comment70273>
Is the user required to specify millis for start and end? Can we use the format for start and end time range as rest of the other commands. i.e 2011-12-01T05:00Z
webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/19520/#comment70268>
logFilter
webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/19520/#comment70269>
Errored out
webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/19520/#comment70272>
Can we populate initial screen of logs with the list of options for log filter?
webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/19520/#comment70270>
Get Logs
- Rohini Palaniswamy
On March 21, 2014, 4:55 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19520/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 4:55 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1737
> https://issues.apache.org/jira/browse/OOZIE-1737
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
> Option can be.
> * Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
> * Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
> offset.
> * End: Server will streaming logs till specified end date. User can provide a valid date or offset.
> * Loglevel : Multiple log levels separated by "|" can be specified.
> * Text: String to search in logs.
> * Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
> matched.
> * Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
> calculated to.
>
>
> In addition to this
> 1. System setting to control log streaming duration.
> 2. Added a option to show log streaming status.
> A label on UI will show if log streaming is in progress, completed or erred.
> 3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
> 4. End the execution when data is date is reached.
> earlier started date and end date is only used to load logs files.
> ......
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 3c780dd
> client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 0466ffe
> core/src/main/java/org/apache/oozie/BundleEngine.java ce7c9c4
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 315a330
> core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
> core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
> core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 2ef351e
> core/src/main/java/org/apache/oozie/util/LogUserParam.java e69de29
> core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
> core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
> core/src/main/resources/oozie-default.xml 34362aa
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
> core/src/test/java/org/apache/oozie/service/TestLogStreamingParam.java e69de29
> core/src/test/resources/userParamTestlog.log e69de29
> docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
> webapp/src/main/webapp/oozie-console.js 0b6cedf
>
> Diff: https://reviews.apache.org/r/19520/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/#review38127
-----------------------------------------------------------
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/19520/#comment70103>
Can you also put similar documentation for the REST docs? You can link to this page so you don't have to rewrite it though.
- Robert Kanter
On March 21, 2014, 4:55 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19520/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 4:55 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1737
> https://issues.apache.org/jira/browse/OOZIE-1737
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
> Option can be.
> * Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
> * Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
> offset.
> * End: Server will streaming logs till specified end date. User can provide a valid date or offset.
> * Loglevel : Multiple log levels separated by "|" can be specified.
> * Text: String to search in logs.
> * Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
> matched.
> * Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
> calculated to.
>
>
> In addition to this
> 1. System setting to control log streaming duration.
> 2. Added a option to show log streaming status.
> A label on UI will show if log streaming is in progress, completed or erred.
> 3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
> 4. End the execution when data is date is reached.
> earlier started date and end date is only used to load logs files.
> ......
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 3c780dd
> client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 0466ffe
> core/src/main/java/org/apache/oozie/BundleEngine.java ce7c9c4
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 315a330
> core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
> core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
> core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 2ef351e
> core/src/main/java/org/apache/oozie/util/LogUserParam.java e69de29
> core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
> core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
> core/src/main/resources/oozie-default.xml 34362aa
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
> core/src/test/java/org/apache/oozie/service/TestLogStreamingParam.java e69de29
> core/src/test/resources/userParamTestlog.log e69de29
> docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
> webapp/src/main/webapp/oozie-console.js 0b6cedf
>
> Diff: https://reviews.apache.org/r/19520/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/#review41198
-----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/19520/#comment74619>
job log filtering options. Please avoid "streaming" in user facing documentation.
client/src/main/java/org/apache/oozie/client/OozieClient.java
<https://reviews.apache.org/r/19520/#comment74621>
call the other getJobLog() method. And have method with lesser number of arguments first.
core/src/main/java/org/apache/oozie/BundleEngine.java
<https://reviews.apache.org/r/19520/#comment74622>
Can we add a constructor that takes jobid and also XLogUserFilterParam?
Below code is always repeated in lot of places.
XLogFilter filter = new XLogFilter(); filter.setParameter(DagXLogInfoService.JOB, jobId);
filter.setUserLogFilter(new XLogUserFilterParam(params));
core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java
<https://reviews.apache.org/r/19520/#comment74628>
There should never be a parse exception from filter.getEndDate(). It should either return a valid date or return null
core/src/main/java/org/apache/oozie/util/XLogFilter.java
<https://reviews.apache.org/r/19520/#comment74639>
return endDate;
core/src/main/java/org/apache/oozie/util/XLogFilter.java
<https://reviews.apache.org/r/19520/#comment74640>
return startDate;
core/src/main/java/org/apache/oozie/util/XLogFilter.java
<https://reviews.apache.org/r/19520/#comment74638>
Add the buffer to jobStartTime and jobEndTime here.
core/src/main/java/org/apache/oozie/util/XLogFilter.java
<https://reviews.apache.org/r/19520/#comment74641>
They can never be null right?
core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/19520/#comment74634>
Make it private
core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/19520/#comment74642>
private
core/src/main/java/org/apache/oozie/util/XLogUserFilterParam.java
<https://reviews.apache.org/r/19520/#comment74636>
Remove all the setters in this class as they are not required
- Rohini Palaniswamy
On April 23, 2014, 7:34 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19520/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 7:34 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1737
> https://issues.apache.org/jira/browse/OOZIE-1737
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
> Option can be.
> * Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
> * Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
> offset.
> * End: Server will streaming logs till specified end date. User can provide a valid date or offset.
> * Loglevel : Multiple log levels separated by "|" can be specified.
> * Text: String to search in logs.
> * Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
> matched.
> * Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
> calculated to.
>
>
> In addition to this
> 1. System setting to control log streaming duration.
> 2. Added a option to show log streaming status.
> A label on UI will show if log streaming is in progress, completed or erred.
> 3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
> 4. End the execution when data is date is reached.
> earlier started date and end date is only used to load logs files.
> ......
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 9929040
> client/src/main/java/org/apache/oozie/client/OozieClient.java 129579a
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java b0dd6cb
> core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
> core/src/main/java/org/apache/oozie/BundleJobBean.java 4c37e57
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 81d98bf
> core/src/main/java/org/apache/oozie/DagEngine.java cad5ddd
> core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 1b18140
> core/src/main/java/org/apache/oozie/service/XLogService.java f9383d0
> core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
> core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 5b65791
> core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java 0a5e8d1
> core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
> core/src/main/java/org/apache/oozie/util/XLogFilter.java e69de29
> core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
> core/src/main/java/org/apache/oozie/util/XLogUserFilterParam.java e69de29
> core/src/main/resources/oozie-default.xml 47fa0e4
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
> core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java c03385d
> core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java 29bca41
> core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 659949f
> core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java 75341aa
> core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java c2630e7
> core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 8d0fd71
> core/src/test/java/org/apache/oozie/util/TestXLogUserFilterParam.java e69de29
> core/src/test/resources/userLogFilterTestlog.log e69de29
> docs/src/site/twiki/DG_CommandLineTool.twiki 222389e
> docs/src/site/twiki/DG_WorkflowReRun.twiki e6cca80
> docs/src/site/twiki/WebServicesAPI.twiki c93fc7f
> webapp/src/main/webapp/oozie-console.js 5f4f847
>
> Diff: https://reviews.apache.org/r/19520/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/#review41328
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On April 24, 2014, 5:10 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19520/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 5:10 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1737
> https://issues.apache.org/jira/browse/OOZIE-1737
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
> Option can be.
> * Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
> * Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
> offset.
> * End: Server will streaming logs till specified end date. User can provide a valid date or offset.
> * Loglevel : Multiple log levels separated by "|" can be specified.
> * Text: String to search in logs.
> * Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
> matched.
> * Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
> calculated to.
>
>
> In addition to this
> 1. System setting to control log streaming duration.
> 2. Added a option to show log streaming status.
> A label on UI will show if log streaming is in progress, completed or erred.
> 3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
> 4. End the execution when data is date is reached.
> earlier started date and end date is only used to load logs files.
> ......
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 9929040
> client/src/main/java/org/apache/oozie/client/OozieClient.java 129579a
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java b0dd6cb
> core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
> core/src/main/java/org/apache/oozie/BundleJobBean.java 4c37e57
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 81d98bf
> core/src/main/java/org/apache/oozie/DagEngine.java cad5ddd
> core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 1b18140
> core/src/main/java/org/apache/oozie/service/XLogService.java f9383d0
> core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
> core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 5b65791
> core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java 0a5e8d1
> core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
> core/src/main/java/org/apache/oozie/util/XLogFilter.java e69de29
> core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
> core/src/main/java/org/apache/oozie/util/XLogUserFilterParam.java e69de29
> core/src/main/resources/oozie-default.xml 47fa0e4
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
> core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java c03385d
> core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java 29bca41
> core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 659949f
> core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java 75341aa
> core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java c2630e7
> core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 8d0fd71
> core/src/test/java/org/apache/oozie/util/TestXLogUserFilterParam.java e69de29
> core/src/test/resources/userLogFilterTestlog.log e69de29
> docs/src/site/twiki/DG_CommandLineTool.twiki 222389e
> docs/src/site/twiki/DG_WorkflowReRun.twiki e6cca80
> docs/src/site/twiki/WebServicesAPI.twiki c93fc7f
> webapp/src/main/webapp/oozie-console.js 5f4f847
>
> Diff: https://reviews.apache.org/r/19520/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/
-----------------------------------------------------------
(Updated April 24, 2014, 5:10 p.m.)
Review request for oozie.
Bugs: OOZIE-1737
https://issues.apache.org/jira/browse/OOZIE-1737
Repository: oozie-git
Description
-------
User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
Option can be.
* Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
* Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
offset.
* End: Server will streaming logs till specified end date. User can provide a valid date or offset.
* Loglevel : Multiple log levels separated by "|" can be specified.
* Text: String to search in logs.
* Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
matched.
* Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
calculated to.
In addition to this
1. System setting to control log streaming duration.
2. Added a option to show log streaming status.
A label on UI will show if log streaming is in progress, completed or erred.
3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
4. End the execution when data is date is reached.
earlier started date and end date is only used to load logs files.
......
Diffs
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 9929040
client/src/main/java/org/apache/oozie/client/OozieClient.java 129579a
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java b0dd6cb
core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
core/src/main/java/org/apache/oozie/BundleJobBean.java 4c37e57
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 81d98bf
core/src/main/java/org/apache/oozie/DagEngine.java cad5ddd
core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 1b18140
core/src/main/java/org/apache/oozie/service/XLogService.java f9383d0
core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 5b65791
core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java 0a5e8d1
core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
core/src/main/java/org/apache/oozie/util/XLogFilter.java e69de29
core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
core/src/main/java/org/apache/oozie/util/XLogUserFilterParam.java e69de29
core/src/main/resources/oozie-default.xml 47fa0e4
core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java c03385d
core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java 29bca41
core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 659949f
core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java 75341aa
core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java c2630e7
core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 8d0fd71
core/src/test/java/org/apache/oozie/util/TestXLogUserFilterParam.java e69de29
core/src/test/resources/userLogFilterTestlog.log e69de29
docs/src/site/twiki/DG_CommandLineTool.twiki 222389e
docs/src/site/twiki/DG_WorkflowReRun.twiki e6cca80
docs/src/site/twiki/WebServicesAPI.twiki c93fc7f
webapp/src/main/webapp/oozie-console.js 5f4f847
Diff: https://reviews.apache.org/r/19520/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/
-----------------------------------------------------------
(Updated April 24, 2014, 5:10 p.m.)
Review request for oozie.
Bugs: OOZIE-1737
https://issues.apache.org/jira/browse/OOZIE-1737
Repository: oozie-git
Description
-------
User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
Option can be.
* Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
* Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
offset.
* End: Server will streaming logs till specified end date. User can provide a valid date or offset.
* Loglevel : Multiple log levels separated by "|" can be specified.
* Text: String to search in logs.
* Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
matched.
* Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
calculated to.
In addition to this
1. System setting to control log streaming duration.
2. Added a option to show log streaming status.
A label on UI will show if log streaming is in progress, completed or erred.
3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
4. End the execution when data is date is reached.
earlier started date and end date is only used to load logs files.
......
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 9929040
client/src/main/java/org/apache/oozie/client/OozieClient.java 129579a
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java b0dd6cb
core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
core/src/main/java/org/apache/oozie/BundleJobBean.java 4c37e57
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 81d98bf
core/src/main/java/org/apache/oozie/DagEngine.java cad5ddd
core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 1b18140
core/src/main/java/org/apache/oozie/service/XLogService.java f9383d0
core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 5b65791
core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java 0a5e8d1
core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
core/src/main/java/org/apache/oozie/util/XLogFilter.java e69de29
core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
core/src/main/java/org/apache/oozie/util/XLogUserFilterParam.java e69de29
core/src/main/resources/oozie-default.xml 47fa0e4
core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java c03385d
core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java 29bca41
core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 659949f
core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java 75341aa
core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java c2630e7
core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 8d0fd71
core/src/test/java/org/apache/oozie/util/TestXLogUserFilterParam.java e69de29
core/src/test/resources/userLogFilterTestlog.log e69de29
docs/src/site/twiki/DG_CommandLineTool.twiki 222389e
docs/src/site/twiki/DG_WorkflowReRun.twiki e6cca80
docs/src/site/twiki/WebServicesAPI.twiki c93fc7f
webapp/src/main/webapp/oozie-console.js 5f4f847
Diff: https://reviews.apache.org/r/19520/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/#review41225
-----------------------------------------------------------
Ship it!
- Rohini Palaniswamy
On April 23, 2014, 9:50 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19520/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 9:50 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1737
> https://issues.apache.org/jira/browse/OOZIE-1737
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
> Option can be.
> * Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
> * Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
> offset.
> * End: Server will streaming logs till specified end date. User can provide a valid date or offset.
> * Loglevel : Multiple log levels separated by "|" can be specified.
> * Text: String to search in logs.
> * Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
> matched.
> * Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
> calculated to.
>
>
> In addition to this
> 1. System setting to control log streaming duration.
> 2. Added a option to show log streaming status.
> A label on UI will show if log streaming is in progress, completed or erred.
> 3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
> 4. End the execution when data is date is reached.
> earlier started date and end date is only used to load logs files.
> ......
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 9929040
> client/src/main/java/org/apache/oozie/client/OozieClient.java 129579a
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java b0dd6cb
> core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
> core/src/main/java/org/apache/oozie/BundleJobBean.java 4c37e57
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 81d98bf
> core/src/main/java/org/apache/oozie/DagEngine.java cad5ddd
> core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 1b18140
> core/src/main/java/org/apache/oozie/service/XLogService.java f9383d0
> core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
> core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 5b65791
> core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java 0a5e8d1
> core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
> core/src/main/java/org/apache/oozie/util/XLogFilter.java e69de29
> core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
> core/src/main/java/org/apache/oozie/util/XLogUserFilterParam.java e69de29
> core/src/main/resources/oozie-default.xml 47fa0e4
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
> core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java c03385d
> core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java 29bca41
> core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 659949f
> core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java 75341aa
> core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java c2630e7
> core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 8d0fd71
> core/src/test/java/org/apache/oozie/util/TestXLogUserFilterParam.java e69de29
> core/src/test/resources/userLogFilterTestlog.log e69de29
> docs/src/site/twiki/DG_CommandLineTool.twiki 222389e
> docs/src/site/twiki/DG_WorkflowReRun.twiki e6cca80
> docs/src/site/twiki/WebServicesAPI.twiki c93fc7f
> webapp/src/main/webapp/oozie-console.js 5f4f847
>
> Diff: https://reviews.apache.org/r/19520/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/#review41230
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java
<https://reviews.apache.org/r/19520/#comment74668>
Can we do a string compare here instead of parsing date every time as it will be costly?
- Rohini Palaniswamy
On April 23, 2014, 9:50 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19520/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 9:50 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1737
> https://issues.apache.org/jira/browse/OOZIE-1737
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
> Option can be.
> * Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
> * Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
> offset.
> * End: Server will streaming logs till specified end date. User can provide a valid date or offset.
> * Loglevel : Multiple log levels separated by "|" can be specified.
> * Text: String to search in logs.
> * Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
> matched.
> * Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
> calculated to.
>
>
> In addition to this
> 1. System setting to control log streaming duration.
> 2. Added a option to show log streaming status.
> A label on UI will show if log streaming is in progress, completed or erred.
> 3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
> 4. End the execution when data is date is reached.
> earlier started date and end date is only used to load logs files.
> ......
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 9929040
> client/src/main/java/org/apache/oozie/client/OozieClient.java 129579a
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java b0dd6cb
> core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
> core/src/main/java/org/apache/oozie/BundleJobBean.java 4c37e57
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 81d98bf
> core/src/main/java/org/apache/oozie/DagEngine.java cad5ddd
> core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 1b18140
> core/src/main/java/org/apache/oozie/service/XLogService.java f9383d0
> core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
> core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 5b65791
> core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java 0a5e8d1
> core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
> core/src/main/java/org/apache/oozie/util/XLogFilter.java e69de29
> core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
> core/src/main/java/org/apache/oozie/util/XLogUserFilterParam.java e69de29
> core/src/main/resources/oozie-default.xml 47fa0e4
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
> core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java c03385d
> core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java 29bca41
> core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 659949f
> core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java 75341aa
> core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java c2630e7
> core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 8d0fd71
> core/src/test/java/org/apache/oozie/util/TestXLogUserFilterParam.java e69de29
> core/src/test/resources/userLogFilterTestlog.log e69de29
> docs/src/site/twiki/DG_CommandLineTool.twiki 222389e
> docs/src/site/twiki/DG_WorkflowReRun.twiki e6cca80
> docs/src/site/twiki/WebServicesAPI.twiki c93fc7f
> webapp/src/main/webapp/oozie-console.js 5f4f847
>
> Diff: https://reviews.apache.org/r/19520/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/
-----------------------------------------------------------
(Updated April 23, 2014, 9:50 p.m.)
Review request for oozie.
Changes
-------
Review comment.
Bugs: OOZIE-1737
https://issues.apache.org/jira/browse/OOZIE-1737
Repository: oozie-git
Description
-------
User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
Option can be.
* Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
* Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
offset.
* End: Server will streaming logs till specified end date. User can provide a valid date or offset.
* Loglevel : Multiple log levels separated by "|" can be specified.
* Text: String to search in logs.
* Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
matched.
* Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
calculated to.
In addition to this
1. System setting to control log streaming duration.
2. Added a option to show log streaming status.
A label on UI will show if log streaming is in progress, completed or erred.
3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
4. End the execution when data is date is reached.
earlier started date and end date is only used to load logs files.
......
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 9929040
client/src/main/java/org/apache/oozie/client/OozieClient.java 129579a
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java b0dd6cb
core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
core/src/main/java/org/apache/oozie/BundleJobBean.java 4c37e57
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 81d98bf
core/src/main/java/org/apache/oozie/DagEngine.java cad5ddd
core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 1b18140
core/src/main/java/org/apache/oozie/service/XLogService.java f9383d0
core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 5b65791
core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java 0a5e8d1
core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
core/src/main/java/org/apache/oozie/util/XLogFilter.java e69de29
core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
core/src/main/java/org/apache/oozie/util/XLogUserFilterParam.java e69de29
core/src/main/resources/oozie-default.xml 47fa0e4
core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java c03385d
core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java 29bca41
core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 659949f
core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java 75341aa
core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java c2630e7
core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 8d0fd71
core/src/test/java/org/apache/oozie/util/TestXLogUserFilterParam.java e69de29
core/src/test/resources/userLogFilterTestlog.log e69de29
docs/src/site/twiki/DG_CommandLineTool.twiki 222389e
docs/src/site/twiki/DG_WorkflowReRun.twiki e6cca80
docs/src/site/twiki/WebServicesAPI.twiki c93fc7f
webapp/src/main/webapp/oozie-console.js 5f4f847
Diff: https://reviews.apache.org/r/19520/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/
-----------------------------------------------------------
(Updated April 23, 2014, 7:34 p.m.)
Review request for oozie.
Changes
-------
addressing review comment.
Bugs: OOZIE-1737
https://issues.apache.org/jira/browse/OOZIE-1737
Repository: oozie-git
Description
-------
User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
Option can be.
* Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
* Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
offset.
* End: Server will streaming logs till specified end date. User can provide a valid date or offset.
* Loglevel : Multiple log levels separated by "|" can be specified.
* Text: String to search in logs.
* Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
matched.
* Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
calculated to.
In addition to this
1. System setting to control log streaming duration.
2. Added a option to show log streaming status.
A label on UI will show if log streaming is in progress, completed or erred.
3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
4. End the execution when data is date is reached.
earlier started date and end date is only used to load logs files.
......
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 9929040
client/src/main/java/org/apache/oozie/client/OozieClient.java 129579a
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java b0dd6cb
core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
core/src/main/java/org/apache/oozie/BundleJobBean.java 4c37e57
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 81d98bf
core/src/main/java/org/apache/oozie/DagEngine.java cad5ddd
core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 1b18140
core/src/main/java/org/apache/oozie/service/XLogService.java f9383d0
core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 5b65791
core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java 0a5e8d1
core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
core/src/main/java/org/apache/oozie/util/XLogFilter.java e69de29
core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
core/src/main/java/org/apache/oozie/util/XLogUserFilterParam.java e69de29
core/src/main/resources/oozie-default.xml 47fa0e4
core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java c03385d
core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java 29bca41
core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 659949f
core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java 75341aa
core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java c2630e7
core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 8d0fd71
core/src/test/java/org/apache/oozie/util/TestXLogUserFilterParam.java e69de29
core/src/test/resources/userLogFilterTestlog.log e69de29
docs/src/site/twiki/DG_CommandLineTool.twiki 222389e
docs/src/site/twiki/DG_WorkflowReRun.twiki e6cca80
docs/src/site/twiki/WebServicesAPI.twiki c93fc7f
webapp/src/main/webapp/oozie-console.js 5f4f847
Diff: https://reviews.apache.org/r/19520/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/#review38818
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/19520/#comment71146>
You can have it as true by default and set to false only when no scope is specified and in bundle
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/19520/#comment71145>
job log filtering
Command line help should be more informative. List out the options of the -logfilter and usage. Refer to FILTER_OPTION in OozieCLI
core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/19520/#comment74152>
XLogFilter filter = new XLogFilter(new XLogUserFilterParam(params));
Other places too
core/src/main/java/org/apache/oozie/DagEngine.java
<https://reviews.apache.org/r/19520/#comment71314>
Remove this
core/src/main/java/org/apache/oozie/DagEngine.java
<https://reviews.apache.org/r/19520/#comment74148>
Date lastTime = job.getEndTime();
core/src/main/java/org/apache/oozie/service/XLogService.java
<https://reviews.apache.org/r/19520/#comment74155>
Can we rename the class to XLogFilter to have consistent naming with other XLog classes?
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74165>
formatting
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74164>
formatting.
Add import instead of full package name
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74167>
isDebugMode()
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74177>
getDebugMessage()
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74159>
Use : or = instead of \ as the separator
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74168>
\n should be fine
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74160>
Follow standard getter/setter convention
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74162>
Camel case.
calculateScanStartEndDate
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74209>
Simplify and make the logic clean. Avoid handling parse exceptions here.
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74181>
Camelcase
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74184>
less than
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74185>
actionLogDuration
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74212>
Please reduce the scan time range.
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74192>
returned
core/src/main/java/org/apache/oozie/util/LogFilter.java
<https://reviews.apache.org/r/19520/#comment74215>
simplify and clean up code without ParseException
core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java
<https://reviews.apache.org/r/19520/#comment74208>
formatting
core/src/main/java/org/apache/oozie/util/UserLogFilter.java
<https://reviews.apache.org/r/19520/#comment74195>
RECENT_OFFSET
core/src/main/java/org/apache/oozie/util/UserLogFilter.java
<https://reviews.apache.org/r/19520/#comment74198>
dateFormat
core/src/main/java/org/apache/oozie/util/UserLogFilter.java
<https://reviews.apache.org/r/19520/#comment74201>
private static final LOG_LEVELS
core/src/main/java/org/apache/oozie/util/UserLogFilter.java
<https://reviews.apache.org/r/19520/#comment74204>
private
have local variables for
startDate, endDate, startOffset, endOffset, recentOffset and getters for them.
core/src/main/java/org/apache/oozie/util/UserLogFilter.java
<https://reviews.apache.org/r/19520/#comment74193>
populate
core/src/main/java/org/apache/oozie/util/UserLogFilter.java
<https://reviews.apache.org/r/19520/#comment74194>
getRecentOffset
This is being already validated. So assign it to a local variable and return integer offset in minutes
core/src/main/java/org/apache/oozie/util/UserLogFilter.java
<https://reviews.apache.org/r/19520/#comment74196>
getSearchPattern
core/src/main/java/org/apache/oozie/util/UserLogFilter.java
<https://reviews.apache.org/r/19520/#comment74202>
Invalid start time : " + getStartDate() , e
core/src/main/java/org/apache/oozie/util/UserLogFilter.java
<https://reviews.apache.org/r/19520/#comment74203>
Invalid end time : " + getEndDate() , e
core/src/main/java/org/apache/oozie/util/UserLogFilter.java
<https://reviews.apache.org/r/19520/#comment74206>
Start time is + getStartDate() + ", End time is " + getEndDate())
core/src/main/java/org/apache/oozie/util/UserLogFilter.java
<https://reviews.apache.org/r/19520/#comment74200>
Supported log levels are
core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/19520/#comment71318>
Move this to streamLog() method and keep the getReader and makeReader methods as is
core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/19520/#comment71320>
Max log scan duration in hours
then exception is thrown to user to reduce the scan duration.
-1 indicates
core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/19520/#comment74171>
Max log scan duration in hours for coordinator job when list of actions are specified.
then exception is thrown to user to reduce the scan duration.
-1 indicates
core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/19520/#comment71325>
This setting is separate from max.log.scan.duration as we want to allow higher durations when actions are specified.
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/19520/#comment74172>
Remove purushah in all places and just start with $
webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/19520/#comment74174>
Please add text here to refer to the documentation link in same server on how to specify search filter.
- Rohini Palaniswamy
On March 25, 2014, 9:23 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19520/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 9:23 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1737
> https://issues.apache.org/jira/browse/OOZIE-1737
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
> Option can be.
> * Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
> * Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
> offset.
> * End: Server will streaming logs till specified end date. User can provide a valid date or offset.
> * Loglevel : Multiple log levels separated by "|" can be specified.
> * Text: String to search in logs.
> * Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
> matched.
> * Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
> calculated to.
>
>
> In addition to this
> 1. System setting to control log streaming duration.
> 2. Added a option to show log streaming status.
> A label on UI will show if log streaming is in progress, completed or erred.
> 3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
> 4. End the execution when data is date is reached.
> earlier started date and end date is only used to load logs files.
> ......
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 3c780dd
> client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 0466ffe
> core/src/main/java/org/apache/oozie/BundleEngine.java ce7c9c4
> core/src/main/java/org/apache/oozie/BundleJobBean.java 2c06035
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 315a330
> core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
> core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 1b18140
> core/src/main/java/org/apache/oozie/service/XLogService.java f9383d0
> core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
> core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 2ef351e
> core/src/main/java/org/apache/oozie/util/LogFilter.java e69de29
> core/src/main/java/org/apache/oozie/util/LogUserParam.java e69de29
> core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java 0a5e8d1
> core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
> core/src/main/java/org/apache/oozie/util/UserLogFilter.java e69de29
> core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
> core/src/main/resources/oozie-default.xml 34362aa
> core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
> core/src/test/java/org/apache/oozie/service/TestLogStreamingParam.java e69de29
> core/src/test/java/org/apache/oozie/service/TestUserLogFilter.java e69de29
> core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java c03385d
> core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java 29bca41
> core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 659949f
> core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java 75341aa
> core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java c2630e7
> core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 8d0fd71
> core/src/test/resources/userLogFilterTestlog.log e69de29
> core/src/test/resources/userParamTestlog.log e69de29
> docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
> docs/src/site/twiki/WebServicesAPI.twiki 4b20075
> webapp/src/main/webapp/oozie-console.js 0b6cedf
>
> Diff: https://reviews.apache.org/r/19520/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 19520: OOZIE-1737 : Oozie log streaming is slow
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19520/
-----------------------------------------------------------
(Updated March 25, 2014, 9:23 p.m.)
Review request for oozie.
Changes
-------
addressing review comment.
Bugs: OOZIE-1737
https://issues.apache.org/jira/browse/OOZIE-1737
Repository: oozie-git
Description
-------
User can provide multiple option as -param <>;<>;<> to make streaming faster and precise.
Option can be.
* Recent: Define offset of recent hours/Min of log to stream. Server will search user query only in recent log duration.
* Start: Start time of log parsing. Oozie server will start parsing logs from start date. User can provide a valid date or
offset.
* End: Server will streaming logs till specified end date. User can provide a valid date or offset.
* Loglevel : Multiple log levels separated by "|" can be specified.
* Text: String to search in logs.
* Limit : Limit number of line to be searched. Log search will end when when n lines(excluding exception) of patten has
matched.
* Debug : Will print log start and end time. This will be useful, if user are not sure what his/her offset will be
calculated to.
In addition to this
1. System setting to control log streaming duration.
2. Added a option to show log streaming status.
A label on UI will show if log streaming is in progress, completed or erred.
3. Many user has complied that get button doesn't look like button. Changes the look of "get log" button.
4. End the execution when data is date is reached.
earlier started date and end date is only used to load logs files.
......
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 3c780dd
client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 0466ffe
core/src/main/java/org/apache/oozie/BundleEngine.java ce7c9c4
core/src/main/java/org/apache/oozie/BundleJobBean.java 2c06035
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 315a330
core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 1b18140
core/src/main/java/org/apache/oozie/service/XLogService.java f9383d0
core/src/main/java/org/apache/oozie/service/XLogStreamingService.java f77794e
core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 2ef351e
core/src/main/java/org/apache/oozie/util/LogFilter.java e69de29
core/src/main/java/org/apache/oozie/util/LogUserParam.java e69de29
core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java 0a5e8d1
core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 8a11780
core/src/main/java/org/apache/oozie/util/UserLogFilter.java e69de29
core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009
core/src/main/resources/oozie-default.xml 34362aa
core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java b4f161a
core/src/test/java/org/apache/oozie/service/TestLogStreamingParam.java e69de29
core/src/test/java/org/apache/oozie/service/TestUserLogFilter.java e69de29
core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java c03385d
core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java 29bca41
core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 659949f
core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java 75341aa
core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java c2630e7
core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 8d0fd71
core/src/test/resources/userLogFilterTestlog.log e69de29
core/src/test/resources/userParamTestlog.log e69de29
docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
docs/src/site/twiki/WebServicesAPI.twiki 4b20075
webapp/src/main/webapp/oozie-console.js 0b6cedf
Diff: https://reviews.apache.org/r/19520/diff/
Testing
-------
Thanks,
Purshotam Shah