You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/01/16 23:40:07 UTC
[GitHub] [incubator-gobblin] arekusuri commented on a change in pull request
#2868: GOBBLIN-1025: Add retry for PK-Chuking iterator
arekusuri commented on a change in pull request #2868: GOBBLIN-1025: Add retry for PK-Chuking iterator
URL: https://github.com/apache/incubator-gobblin/pull/2868#discussion_r367705299
##########
File path: gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceConfigurationKeys.java
##########
@@ -26,12 +26,12 @@ private SalesforceConfigurationKeys() {
public static final String BULK_API_USE_QUERY_ALL = "salesforce.bulkApiUseQueryAll";
// pk-chunking
- public static final String PK_CHUNKING_TEST_BATCH_ID_LIST = "salesforce.pkChunking.testBatchIdList";
- public static final String PK_CHUNKING_TEST_JOB_ID = "salesforce.pkChunking.testJobId";
+ public static final String BULK_TEST_JOB_ID = "salesforce.bulk.test.job.id";
Review comment:
Thanks! Changed to
```
public static final String BULK_TEST_JOB_ID = "salesforce.bulk.testJobId";
public static final String BULK_TEST_BATCH_ID_LIST = "salesforce.bulk.testBatchIds";
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services