You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/07 10:54:01 UTC

[GitHub] [airflow] ashb opened a new pull request, #24896: Don't add init.py files to __pycache__ folders.

ashb opened a new pull request, #24896:
URL: https://github.com/apache/airflow/pull/24896

   For instance, after running pytest I had these files created by this step:
   
   ```
   Create missing init.py files in tests..................................................Failed
   - hook id: create-missing-init-py-files-tests
   - exit code: 1
   
    Created /home/ash/code/airflow/airflow/tests/__pycache__/__init__.py
    Created /home/ash/code/airflow/airflow/tests/models/__pycache__/__init__.py
    Created /home/ash/code/airflow/airflow/tests/test_utils/__pycache__/__init__.py
    Created /home/ash/code/airflow/airflow/tests/test_utils/perf/__pycache__/__init__.py
    Created /home/ash/code/airflow/airflow/tests/test_utils/perf/perf_kit/__pycache__/__init__.py
   ```
   
   (This change also stops the `os.walkdir` from needlessly recursing in to
   test_logs folder as well.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #24896: Don't add init.py files to __pycache__ folders.

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24896:
URL: https://github.com/apache/airflow/pull/24896


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #24896: Don't add init.py files to __pycache__ folders.

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24896:
URL: https://github.com/apache/airflow/pull/24896#issuecomment-1177754666

   BTW. I've learned since about Path.rglob('*) which would likely be better (I hate os.walldir's interface)  :) but maybe one day.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #24896: Don't add init.py files to __pycache__ folders.

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24896:
URL: https://github.com/apache/airflow/pull/24896#issuecomment-1177756547

   (Though performance wise walkdir can be better optimized likely) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #24896: Don't add init.py files to __pycache__ folders.

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24896:
URL: https://github.com/apache/airflow/pull/24896#issuecomment-1177752527

   Not relevant build failure. Merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org