You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/11/15 06:26:28 UTC
[GitHub] [incubator-eventmesh] walleliu1016 opened a new issue, #2220: [Enhancement] rename push request function name
walleliu1016 opened a new issue, #2220:
URL: https://github.com/apache/incubator-eventmesh/issues/2220
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
https://github.com/apache/incubator-eventmesh/blob/476ba57a68c8aa1f302d70e3ca380f02ecbccfd1/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/push/MessageHandler.java#L85
function name is _**createHttpPushRequest**_
but create request based on different grpc type.
`
private AbstractPushRequest createHttpPushRequest(HandleMsgContext handleMsgContext) {
GrpcType grpcType = handleMsgContext.getGrpcType();
if (GrpcType.WEBHOOK.equals(grpcType)) {
return new WebhookPushRequest(handleMsgContext, waitingRequests);
} else {
return new StreamPushRequest(handleMsgContext, waitingRequests);
}
}
`
### Describe the solution you'd like
update the function name
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] walleliu1016 closed issue #2220: [Enhancement] rename push request function name
Posted by GitBox <gi...@apache.org>.
walleliu1016 closed issue #2220: [Enhancement] rename push request function name
URL: https://github.com/apache/incubator-eventmesh/issues/2220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org