[GitHub] [spark] amaliujia commented on a diff in pull request #38858: [SPARK-41346][CONNECT][PYTHON] Implement `asc` and `desc` functions

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38858:
URL: https://github.com/apache/spark/pull/38858#discussion_r1036698050


##########
python/pyspark/sql/connect/column.py:
##########
@@ -701,11 +688,23 @@ def to_plan(self, session: "SparkConnectClient") -> proto.Expression:
     def alias(self, *alias: str, **kwargs: Any) -> "Column":
         return Column(self._expr.alias(*alias, **kwargs))
 
+    def asc(self) -> "Column":
+        return self.asc_nulls_first()

Review Comment:
   oh I didn't know `asc` is `asc_nulls_first`. This is a good simplification. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org