You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2018/02/13 22:48:52 UTC

[native-toolchain-CR](cdh5.x) Quiet down file transfers, rename target platform variable 

Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9314


Change subject: Quiet down file transfers, rename target platform variable
......................................................................

Quiet down file transfers, rename target platform variable

1. File download with wget and maven upload all have verbose progress
indicators. This increases noise in the build logs making it hard
to navigate to relevant details.

This patch:
- changes wget to use a less chatty progress bar
- changes maven upload to batch mode and bumps log level to warnings
  or worse
- tells "aws s3 cp" to report errors only, adding an explicit echo to
  report file copy source and estination.

2. When the toolchain is built in an automated environment (e.g. using
a Jenkins job), the build target platform identifier is communicated
in an environment variable. This patch renames this variable to
BUILD_TARGET_LABEL to untangle it from Jenkins-defined variables and
to make its role more explicit.

Tested by rebuilding the toolchain with the new script, using
a conforming Jenkins job; all artifacts were prodiced with correct
package name suffixes. Results are stored at:
s3://impala-toolchain-test/build/33-a25ad7b25c/

Change-Id: Iaa4349a8ae0ab5bde2dabf5ff65db0f2db4b9ba9
---
M functions.sh
M init.sh
2 files changed, 17 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/14/9314/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa4349a8ae0ab5bde2dabf5ff65db0f2db4b9ba9
Gerrit-Change-Number: 9314
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>

[native-toolchain-CR](cdh5.x) Quiet down file transfers, rename target platform variable

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9314 )

Change subject: Quiet down file transfers, rename target platform variable
......................................................................


Patch Set 1: Code-Review+2

Clean cherry-pick


-- 
To view, visit http://gerrit.cloudera.org:8080/9314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa4349a8ae0ab5bde2dabf5ff65db0f2db4b9ba9
Gerrit-Change-Number: 9314
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Feb 2018 22:49:26 +0000
Gerrit-HasComments: No

[native-toolchain-CR](cdh5.x) Quiet down file transfers, rename target platform variable

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9314 )

Change subject: Quiet down file transfers, rename target platform variable
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/9314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa4349a8ae0ab5bde2dabf5ff65db0f2db4b9ba9
Gerrit-Change-Number: 9314
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Feb 2018 22:49:28 +0000
Gerrit-HasComments: No

[native-toolchain-CR](cdh5.x) Quiet down file transfers, rename target platform variable

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9314 )

Change subject: Quiet down file transfers, rename target platform variable
......................................................................

Quiet down file transfers, rename target platform variable

1. File download with wget and maven upload all have verbose progress
indicators. This increases noise in the build logs making it hard
to navigate to relevant details.

This patch:
- changes wget to use a less chatty progress bar
- changes maven upload to batch mode and bumps log level to warnings
  or worse
- tells "aws s3 cp" to report errors only, adding an explicit echo to
  report file copy source and estination.

2. When the toolchain is built in an automated environment (e.g. using
a Jenkins job), the build target platform identifier is communicated
in an environment variable. This patch renames this variable to
BUILD_TARGET_LABEL to untangle it from Jenkins-defined variables and
to make its role more explicit.

Tested by rebuilding the toolchain with the new script, using
a conforming Jenkins job; all artifacts were prodiced with correct
package name suffixes. Results are stored at:
s3://impala-toolchain-test/build/33-a25ad7b25c/

Change-Id: Iaa4349a8ae0ab5bde2dabf5ff65db0f2db4b9ba9
---
M functions.sh
M init.sh
2 files changed, 17 insertions(+), 10 deletions(-)

Approvals:
  Thomas Tauber-Marshall: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa4349a8ae0ab5bde2dabf5ff65db0f2db4b9ba9
Gerrit-Change-Number: 9314
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>