You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/11 05:06:44 UTC
[GitHub] [shardingsphere] totalo opened a new pull request, #22071: Independent project build process for example generator IT
totalo opened a new pull request, #22071:
URL: https://github.com/apache/shardingsphere/pull/22071
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
-
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #22071: Independent project build process for example generator IT
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #22071:
URL: https://github.com/apache/shardingsphere/pull/22071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on a diff in pull request #22071: Independent project build process for example generator IT
Posted by GitBox <gi...@apache.org>.
totalo commented on code in PR #22071:
URL: https://github.com/apache/shardingsphere/pull/22071#discussion_r1020762297
##########
.github/workflows/nightly-it-example-generator.yml:
##########
@@ -25,11 +25,32 @@ env:
MAVEN_OPTS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.class=standard -Dmaven.wagon.http.retryHandler.count=3 -Dcheckstyle.skip=true -Dspotless.apply.skip=true -Dmaven.javadoc.skip=true
jobs:
+ build-cache:
+ if: github.repository == 'apache/shardingsphere'
+ name: Build Cache
+ runs-on: ubuntu-latest
+ timeout-minutes: 90
+ steps:
+ - uses: actions/checkout@v3
+ - uses: actions/setup-java@v3
+ with:
+ distribution: 'temurin'
+ java-version: '8'
+ - uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: shardingsphere-maven-third-party-cache-${{ github.sha }}
+ restore-keys: |
+ shardingsphere-maven-third-party-cache-
+ shardingsphere-maven-third-party-
+ - name: Build with Maven
+ run: ./mvnw -B -T1C -ntp clean install -DskipITs -DskipTests
example-generator:
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on a diff in pull request #22071: Independent project build process for example generator IT
Posted by GitBox <gi...@apache.org>.
totalo commented on code in PR #22071:
URL: https://github.com/apache/shardingsphere/pull/22071#discussion_r1020764592
##########
.github/workflows/nightly-it-example-generator.yml:
##########
@@ -25,11 +25,32 @@ env:
MAVEN_OPTS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.class=standard -Dmaven.wagon.http.retryHandler.count=3 -Dcheckstyle.skip=true -Dspotless.apply.skip=true -Dmaven.javadoc.skip=true
jobs:
- example-generator:
+ build-cache:
+ if: github.repository == 'apache/shardingsphere'
+ name: Build Cache
+ runs-on: ubuntu-latest
+ timeout-minutes: 90
+ steps:
+ - uses: actions/checkout@v3
+ - uses: actions/setup-java@v3
+ with:
+ distribution: 'temurin'
+ java-version: '8'
+ - uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: shardingsphere-maven-third-party-cache-${{ github.sha }}
+ restore-keys: |
+ shardingsphere-maven-third-party-cache-
+ shardingsphere-maven-third-party-
+ - name: Build with Maven
+ run: ./mvnw -B -T1C -ntp clean install -DskipITs -DskipTests
+ Generate-and-test-examples:
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #22071: Independent project build process for example generator IT
Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #22071:
URL: https://github.com/apache/shardingsphere/pull/22071#discussion_r1020728252
##########
.github/workflows/nightly-it-example-generator.yml:
##########
@@ -25,11 +25,32 @@ env:
MAVEN_OPTS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.class=standard -Dmaven.wagon.http.retryHandler.count=3 -Dcheckstyle.skip=true -Dspotless.apply.skip=true -Dmaven.javadoc.skip=true
jobs:
+ build-cache:
+ if: github.repository == 'apache/shardingsphere'
+ name: Build Cache
+ runs-on: ubuntu-latest
+ timeout-minutes: 90
+ steps:
+ - uses: actions/checkout@v3
+ - uses: actions/setup-java@v3
+ with:
+ distribution: 'temurin'
+ java-version: '8'
+ - uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: shardingsphere-maven-third-party-cache-${{ github.sha }}
+ restore-keys: |
+ shardingsphere-maven-third-party-cache-
+ shardingsphere-maven-third-party-
+ - name: Build with Maven
+ run: ./mvnw -B -T1C -ntp clean install -DskipITs -DskipTests
example-generator:
Review Comment:
how about rename job name as `generate-and-test-examples`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #22071: Independent project build process for example generator IT
Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #22071:
URL: https://github.com/apache/shardingsphere/pull/22071#discussion_r1020764203
##########
.github/workflows/nightly-it-example-generator.yml:
##########
@@ -25,11 +25,32 @@ env:
MAVEN_OPTS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.class=standard -Dmaven.wagon.http.retryHandler.count=3 -Dcheckstyle.skip=true -Dspotless.apply.skip=true -Dmaven.javadoc.skip=true
jobs:
- example-generator:
+ build-cache:
+ if: github.repository == 'apache/shardingsphere'
+ name: Build Cache
+ runs-on: ubuntu-latest
+ timeout-minutes: 90
+ steps:
+ - uses: actions/checkout@v3
+ - uses: actions/setup-java@v3
+ with:
+ distribution: 'temurin'
+ java-version: '8'
+ - uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: shardingsphere-maven-third-party-cache-${{ github.sha }}
+ restore-keys: |
+ shardingsphere-maven-third-party-cache-
+ shardingsphere-maven-third-party-
+ - name: Build with Maven
+ run: ./mvnw -B -T1C -ntp clean install -DskipITs -DskipTests
+ Generate-and-test-examples:
Review Comment:
Please use lower case for all job name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org