You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/05 09:37:25 UTC

[GitHub] tzulitai opened a new pull request #7243: [FLINK-11075] [core] Remove irrelevant code in CompatibilityUtil#resolveCompatibilityResult

tzulitai opened a new pull request #7243: [FLINK-11075] [core] Remove irrelevant code in CompatibilityUtil#resolveCompatibilityResult
URL: https://github.com/apache/flink/pull/7243
 
 
   ## What is the purpose of the change
   
   This PR removes irrelevant code in `CompatibilityUtil#resolveCompatibilityResult`, after the behaviour of carrying a covert deserializer in the compatibility result is no longer relevant since Flink 1.7.
   
   ## Brief change log
   
   - Since `initialResult` can only every be `compatible` or `requires migration` and never carry a convert deserializer, it can be returned already without further checks. The redundant checks are removed.
   - Simplify the method signature after some parameters are no longer used. 
   
   ## Verifying this change
   
   This is only a code cleanup.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services