You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by macdonst <gi...@git.apache.org> on 2015/09/09 06:01:33 UTC
[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-ios/pull/160
CB-9328 Use ios-sim as a node module, not a CLI utility
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cordova-ios CB-9328
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #160
----
commit 3663e6ac6a39a13c33adab64e38a326b27d5e84b
Author: Simon MacDonald <si...@gmail.com>
Date: 2015-09-09T04:00:09Z
CB-9328 Use ios-sim as a node module, not a CLI utility
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-139688293
yup. But not sure where we would add this dependency... we could just check-in the `node_modules` in the `bin/templates/scripts/cordova/lib` folder (after installing ios-sim there). There is already a `node_modules` in `bin`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-139687129
`require('ios-sim')` is called here, but how is the module installed?
ideally it should be installed when you create the project, inside the project, or part of cordova-lib.
It should be part of the platform, if the CLI could run "npm install" on the platform.
Trying to avoid making the user run "npm install ios-sim"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...
Posted by macdonst <gi...@git.apache.org>.
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-139687899
@shazron thanks for the feedback, I meant to ask about including npm modules along with the cordova-ios. This way folks would not need to `npm install ios-sim` right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-140575717
Just tested with `cordova emulate` -- verified I didn't have any ios-sim installed anywhere before I did so. I suppose 5.0.1 is not needed since that was a patch for the CLI way anyways..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-140576401
We also can get rid of all checks for the ios-sim requirement: https://github.com/apache/cordova-ios/blob/f2ade2282b56a560199f493a5feb32481a16b6d5/bin/lib/check_reqs.js#L58-L60
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...
Posted by macdonst <gi...@git.apache.org>.
Github user macdonst closed the pull request at:
https://github.com/apache/cordova-ios/pull/160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...
Posted by macdonst <gi...@git.apache.org>.
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-140149314
@shazron okay, I think I've got it. I don't want to merge until I get a second set of eyes though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...
Posted by macdonst <gi...@git.apache.org>.
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-140620008
@shazron Yeah, I didn't bother to update to 5.0.1 as it only affects the project when used as a CLI but I can do that if you'd like.
I actually did get rid of the checks before but forgot to stage the file so I just updated the commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-140233427
thanks @macdonst I suppose this needs to get the patched 5.0.1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-140621633
Nah no need to update to 5.0.1, thanks Simon! I'll give it a spin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org