You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by in...@apache.org on 2008/01/14 06:58:54 UTC

svn commit: r611718 - in /webservices/synapse/branches/1.1.1/modules/core/src/main/java/org/apache/synapse/statistics: Statistics.java impl/ProxyServiceStatisticsStack.java

Author: indika
Date: Sun Jan 13 21:58:51 2008
New Revision: 611718

URL: http://svn.apache.org/viewvc?rev=611718&view=rev
Log:
minor improvements to statistics collecting

Modified:
    webservices/synapse/branches/1.1.1/modules/core/src/main/java/org/apache/synapse/statistics/Statistics.java
    webservices/synapse/branches/1.1.1/modules/core/src/main/java/org/apache/synapse/statistics/impl/ProxyServiceStatisticsStack.java

Modified: webservices/synapse/branches/1.1.1/modules/core/src/main/java/org/apache/synapse/statistics/Statistics.java
URL: http://svn.apache.org/viewvc/webservices/synapse/branches/1.1.1/modules/core/src/main/java/org/apache/synapse/statistics/Statistics.java?rev=611718&r1=611717&r2=611718&view=diff
==============================================================================
--- webservices/synapse/branches/1.1.1/modules/core/src/main/java/org/apache/synapse/statistics/Statistics.java (original)
+++ webservices/synapse/branches/1.1.1/modules/core/src/main/java/org/apache/synapse/statistics/Statistics.java Sun Jan 13 21:58:51 2008
@@ -45,10 +45,16 @@
      * @param isFault - A boolean value that indicate whether falut has occured or not
      */
     public void update(long inTime, long outTime, boolean isFault) {
+
+        if (outTime < 0 || inTime < 0) {
+            return;
+        }
+
         count++;
         if (isFault) {
             faultCount++;
         }
+
         long responseTime = outTime - inTime;
         if (maxProcessingTime < responseTime) {
             maxProcessingTime = responseTime;

Modified: webservices/synapse/branches/1.1.1/modules/core/src/main/java/org/apache/synapse/statistics/impl/ProxyServiceStatisticsStack.java
URL: http://svn.apache.org/viewvc/webservices/synapse/branches/1.1.1/modules/core/src/main/java/org/apache/synapse/statistics/impl/ProxyServiceStatisticsStack.java?rev=611718&r1=611717&r2=611718&view=diff
==============================================================================
--- webservices/synapse/branches/1.1.1/modules/core/src/main/java/org/apache/synapse/statistics/impl/ProxyServiceStatisticsStack.java (original)
+++ webservices/synapse/branches/1.1.1/modules/core/src/main/java/org/apache/synapse/statistics/impl/ProxyServiceStatisticsStack.java Sun Jan 13 21:58:51 2008
@@ -68,16 +68,18 @@
      */
     public void reportToStatisticsCollector(StatisticsCollector statisticsCollector,
                                             boolean isFault) {
-        if (proxyServiceName != null && isStatisticsEnable && inTimeForInFlow != -1) {
-            inTimeForOutFlow = System.currentTimeMillis();
-            isOUTFault = isFault;
-            statisticsCollector.reportForProxyService(proxyServiceName, false,
+        synchronized (this) {
+            if (proxyServiceName != null && isStatisticsEnable && inTimeForInFlow != -1) {
+                inTimeForOutFlow = System.currentTimeMillis();
+                isOUTFault = isFault;
+                statisticsCollector.reportForProxyService(proxyServiceName, false,
                     inTimeForInFlow, inTimeForOutFlow, isINFault);
-            inTimeForInFlow = -1;
-        } else if (inTimeForOutFlow != -1) {
-            statisticsCollector.reportForProxyService(proxyServiceName, true,
+                inTimeForInFlow = -1;
+            } else if (inTimeForOutFlow != -1) {
+                statisticsCollector.reportForProxyService(proxyServiceName, true,
                     inTimeForOutFlow, System.currentTimeMillis(), isFault);
-            inTimeForOutFlow = -1;
+                inTimeForOutFlow = -1;
+            }
         }
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: synapse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: synapse-dev-help@ws.apache.org