You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/17 12:45:59 UTC
[GitHub] [arrow-rs] alamb commented on a change in pull request #1446: Fix generate_interval_case in integration test
alamb commented on a change in pull request #1446:
URL: https://github.com/apache/arrow-rs/pull/1446#discussion_r829075553
##########
File path: arrow/src/compute/kernels/cast.rs
##########
@@ -228,6 +228,20 @@ pub fn can_cast_types(from_type: &DataType, to_type: &DataType) -> bool {
IntervalUnit::DayTime => true,
IntervalUnit::MonthDayNano => false, // Native type is i128
}
+ },
+ (Int32, Interval(to_type)) => {
Review comment:
👍
##########
File path: arrow/src/compute/kernels/cast.rs
##########
@@ -228,6 +228,20 @@ pub fn can_cast_types(from_type: &DataType, to_type: &DataType) -> bool {
IntervalUnit::DayTime => true,
IntervalUnit::MonthDayNano => false, // Native type is i128
}
+ },
+ (Int32, Interval(to_type)) => {
Review comment:
I double checked the format at this looks right to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org