[GitHub] [daffodil] tuxji commented on a change in pull request #728: Update genjavadoc-plugin to 0.18_2.13.8

[GitBox <gi...@apache.org>]

tuxji commented on a change in pull request #728:
URL: https://github.com/apache/daffodil/pull/728#discussion_r784471788



##########
File path: daffodil-japi/build.sbt
##########
@@ -18,7 +18,7 @@
 enablePlugins(GenJavadocPlugin)
 enablePlugins(PublishJavadocPlugin)
 
-unidocGenjavadocVersion := "0.18_2.12.15"
+unidocGenjavadocVersion := "0.18_2.13.8"

Review comment:
       I looked at <https://github.com/sbt/sbt-unidoc/issues/110>, <https://github.com/sbt/sbt-unidoc>, and <https://github.com/apache/daffodil/blame/main/daffodil-japi/build.sbt> to determine why we need that unidocGenjavadocVersion line (we need it because the old default, 0.15, doesn't work anymore, a PR changed it to 0.18 in the sbt-unidoc repo only yesterday, and a new sbt-unidoc release hasn't been made yet), whether we should keep that unidocGenjavadocVersion line (yes because the default in the last released sbt-unidoc version is still 0.15), when we first added that unidocGenjavadocVersion line (in your PR <https://github.com/apache/daffodil/pull/398> almost two years ago), and why it changed to include a Scala cross version (blame Scala Steward for adding it in PR <https://github.com/apache/daffodil/pull/634>).  I agree you can change it back to "0.18" and leave it there, but Scala Stewart may add a new Scala cross version to it again in the future.  If you change that line
  anyway, you probably want to add a comment to remind us that the cross version shouldn't be needed and find a way to tell Scala Stewart not to add a cross version again (if possible).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org