You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/11/24 10:13:32 UTC
[GitHub] [james-project] quantranhong1999 opened a new pull request #760: JAMES-3534 Identity/destroy should not fail for identities whose alias is deleted
quantranhong1999 opened a new pull request #760:
URL: https://github.com/apache/james-project/pull/760
After writing the test and having a look again at the delete API logic, I realize that we don't need to change any logic to the destroy case.
Still the test for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #760: JAMES-3534 Identity/destroy should not fail for identities whose alias is deleted
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #760:
URL: https://github.com/apache/james-project/pull/760#issuecomment-979693366
Needs a rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael merged pull request #760: JAMES-3534 Identity/destroy should not fail for identities whose alias is deleted
Posted by GitBox <gi...@apache.org>.
Arsnael merged pull request #760:
URL: https://github.com/apache/james-project/pull/760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael edited a comment on pull request #760: JAMES-3534 Identity/destroy should not fail for identities whose alias is deleted
Posted by GitBox <gi...@apache.org>.
Arsnael edited a comment on pull request #760:
URL: https://github.com/apache/james-project/pull/760#issuecomment-983216331
Still the same... I don't think it's maven deps or coming from us. But maybe something directly wrong with the worker. You have issues like this:
```
java.lang.ExceptionInInitializerError
Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed
Caused by: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=<resolving>, imagePullPolicy=DefaultPullPolicy())
Caused by: com.github.dockerjava.api.exception.DockerClientException: Failed to parse docker configuration file
Caused by: java.io.IOException: Failed to parse docker config.json
Caused by: org.testcontainers.shaded.com.fasterxml.jackson.databind.JsonMappingException:
No content to map due to end-of-input
at [Source: /home/jenkins/.docker/config.json; line: 1, column: 0]
```
No idea what the hell is that `/home/jenkins/.docker/config.json` file... I will try to open a duplicated PR, to force the build on an other worker. I don't see better solution.
EDIT: Or maybe not... I just saw after I removed my extra commit (that was useless) it started a build on an other worker. Let's see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 edited a comment on pull request #760: JAMES-3534 Identity/destroy should not fail for identities whose alias is deleted
Posted by GitBox <gi...@apache.org>.
quantranhong1999 edited a comment on pull request #760:
URL: https://github.com/apache/james-project/pull/760#issuecomment-982501429
> Do we have troubles with a worker again?
Maybe. The NoClassDefFoundError seems like the CI can not load properly the maven dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on pull request #760: JAMES-3534 Identity/destroy should not fail for identities whose alias is deleted
Posted by GitBox <gi...@apache.org>.
quantranhong1999 commented on pull request #760:
URL: https://github.com/apache/james-project/pull/760#issuecomment-982501429
> Do we have troubles with a worker again?
Maybe. The NoClassDefFoundError seems like the CI can not load properly the maven dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #760: JAMES-3534 Identity/destroy should not fail for identities whose alias is deleted
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #760:
URL: https://github.com/apache/james-project/pull/760#issuecomment-982510332
Ok I'm retrying with adding an extra cleanup in the CI build, see if we get a better result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #760: JAMES-3534 Identity/destroy should not fail for identities whose alias is deleted
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #760:
URL: https://github.com/apache/james-project/pull/760#issuecomment-983216331
Still the same... I don't think it's maven deps or coming from us. But maybe something directly wrong with the worker. You have issues like this:
```
java.lang.ExceptionInInitializerError
Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed
Caused by: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=<resolving>, imagePullPolicy=DefaultPullPolicy())
Caused by: com.github.dockerjava.api.exception.DockerClientException: Failed to parse docker configuration file
Caused by: java.io.IOException: Failed to parse docker config.json
Caused by: org.testcontainers.shaded.com.fasterxml.jackson.databind.JsonMappingException:
No content to map due to end-of-input
at [Source: /home/jenkins/.docker/config.json; line: 1, column: 0]
```
No idea what the hell is that `/home/jenkins/.docker/config.json` file... I will try to open a duplicated PR, to force the build on an other worker. I don't see better solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on pull request #760: JAMES-3534 Identity/destroy should not fail for identities whose alias is deleted
Posted by GitBox <gi...@apache.org>.
quantranhong1999 commented on pull request #760:
URL: https://github.com/apache/james-project/pull/760#issuecomment-978997261
Added commit https://github.com/apache/james-project/pull/760/commits/19731a2d3adf322abb3820e77153f2e6ca69632f following 4 test cases Benoit suggested.
I think this is more likely to belong to Tung work (fix bug for get and update case).
@vttranlina you can cherry-pick this commit. And I will remove this commit after you take it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #760: JAMES-3534 Identity/destroy should not fail for identities whose alias is deleted
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #760:
URL: https://github.com/apache/james-project/pull/760#issuecomment-978950797
Read it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #760: JAMES-3534 Identity/destroy should not fail for identities whose alias is deleted
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #760:
URL: https://github.com/apache/james-project/pull/760#issuecomment-982498495
I don't get why it keeps failing with the same errors... It makes no sense, the code in backends has not been modified. And also that code is used in https://github.com/apache/james-project/pull/761 that is green.....
Do we have troubles with a worker again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org