You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/07/03 05:08:06 UTC
[GitHub] [kylin] zzcclp opened a new pull request #1303: KYLIN-4618 Upgrade kylin docker image for kylin 3.1.0
zzcclp opened a new pull request #1303:
URL: https://github.com/apache/kylin/pull/1303
Upgrade kylin docker image for kylin 3.1.0
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on a change in pull request #1303: KYLIN-4618 Upgrade kylin docker image for kylin 3.1.0
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on a change in pull request #1303:
URL: https://github.com/apache/kylin/pull/1303#discussion_r449842229
##########
File path: docker/Dockerfile
##########
@@ -18,17 +18,18 @@
# Docker image for apache kylin, based on the Hadoop image
FROM hadoop2.7-all-in-one
-ENV KYLIN_VERSION 3.0.1
+ENV KYLIN_VERSION 3.1.0
ENV KYLIN_HOME /home/admin/apache-kylin-$KYLIN_VERSION-bin-hbase1x
# Download released Kylin
-RUN wget https://archive.apache.org/dist/kylin/apache-kylin-$KYLIN_VERSION/apache-kylin-$KYLIN_VERSION-bin-hbase1x.tar.gz \
+RUN wget https://downloads.apache.org/kylin/apache-kylin-$KYLIN_VERSION/apache-kylin-$KYLIN_VERSION-bin-hbase1x.tar.gz \
Review comment:
I may not accpect this change from **archive** to "mirror", older version is not accessible in mirror, like 2.5.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1303: KYLIN-4618 Upgrade kylin docker image for kylin 3.1.0
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1303:
URL: https://github.com/apache/kylin/pull/1303#issuecomment-655389282
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on a change in pull request #1303: KYLIN-4618 Upgrade kylin docker image for kylin 3.1.0
Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1303:
URL: https://github.com/apache/kylin/pull/1303#discussion_r449942603
##########
File path: docker/Dockerfile
##########
@@ -18,17 +18,18 @@
# Docker image for apache kylin, based on the Hadoop image
FROM hadoop2.7-all-in-one
-ENV KYLIN_VERSION 3.0.1
+ENV KYLIN_VERSION 3.1.0
ENV KYLIN_HOME /home/admin/apache-kylin-$KYLIN_VERSION-bin-hbase1x
# Download released Kylin
-RUN wget https://archive.apache.org/dist/kylin/apache-kylin-$KYLIN_VERSION/apache-kylin-$KYLIN_VERSION-bin-hbase1x.tar.gz \
+RUN wget https://downloads.apache.org/kylin/apache-kylin-$KYLIN_VERSION/apache-kylin-$KYLIN_VERSION-bin-hbase1x.tar.gz \
Review comment:
it can't download kylin 3.1.0 from https://archive.apache.org at that time, so I changed to "mirror".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on a change in pull request #1303: KYLIN-4618 Upgrade kylin docker image for kylin 3.1.0
Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1303:
URL: https://github.com/apache/kylin/pull/1303#discussion_r449995653
##########
File path: docker/Dockerfile
##########
@@ -18,17 +18,18 @@
# Docker image for apache kylin, based on the Hadoop image
FROM hadoop2.7-all-in-one
-ENV KYLIN_VERSION 3.0.1
+ENV KYLIN_VERSION 3.1.0
ENV KYLIN_HOME /home/admin/apache-kylin-$KYLIN_VERSION-bin-hbase1x
# Download released Kylin
-RUN wget https://archive.apache.org/dist/kylin/apache-kylin-$KYLIN_VERSION/apache-kylin-$KYLIN_VERSION-bin-hbase1x.tar.gz \
+RUN wget https://downloads.apache.org/kylin/apache-kylin-$KYLIN_VERSION/apache-kylin-$KYLIN_VERSION-bin-hbase1x.tar.gz \
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on a change in pull request #1303: KYLIN-4618 Upgrade kylin docker image for kylin 3.1.0
Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1303:
URL: https://github.com/apache/kylin/pull/1303#discussion_r449941587
##########
File path: docker/Dockerfile_hadoop
##########
@@ -91,6 +89,7 @@ RUN wget https://archive.apache.org/dist/spark/spark-$SPARK_VERSION/spark-$SPARK
&& cp $HIVE_HOME/conf/hive-site.xml $SPARK_HOME/conf \
&& cp $SPARK_HOME/yarn/*.jar $HADOOP_HOME/share/hadoop/yarn/lib
RUN cp $HIVE_HOME/lib/mysql-connector-java-5.1.24.jar $SPARK_HOME/jars
+RUN cp $HBASE_HOME/lib/hbase-protocol-1.1.2.jar $SPARK_HOME/jars
Review comment:
when build with spark, it needs this hbase-protocol.jar, otherwise it throws 'NoClassDefFoundError: org/apache/hadoop/hbase/protobuf/generated/HFileProtos'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on a change in pull request #1303: KYLIN-4618 Upgrade kylin docker image for kylin 3.1.0
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on a change in pull request #1303:
URL: https://github.com/apache/kylin/pull/1303#discussion_r449841921
##########
File path: docker/Dockerfile_hadoop
##########
@@ -91,6 +89,7 @@ RUN wget https://archive.apache.org/dist/spark/spark-$SPARK_VERSION/spark-$SPARK
&& cp $HIVE_HOME/conf/hive-site.xml $SPARK_HOME/conf \
&& cp $SPARK_HOME/yarn/*.jar $HADOOP_HOME/share/hadoop/yarn/lib
RUN cp $HIVE_HOME/lib/mysql-connector-java-5.1.24.jar $SPARK_HOME/jars
+RUN cp $HBASE_HOME/lib/hbase-protocol-1.1.2.jar $SPARK_HOME/jars
Review comment:
Wht should we add this line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls edited a comment on pull request #1303: KYLIN-4618 Upgrade kylin docker image for kylin 3.1.0
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1303:
URL: https://github.com/apache/kylin/pull/1303#issuecomment-653366697
## Pull Request Test Coverage Report for [Build 6106](https://coveralls.io/builds/31875051)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **3** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.01%**) to **28.061%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/31875051/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42) | 1 | 83.33% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/31875051/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/31875051) |
| :-- | --: |
| Change from base [Build 6105](https://coveralls.io/builds/31867659): | 0.01% |
| Covered Lines: | 26223 |
| Relevant Lines: | 93449 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on a change in pull request #1303: KYLIN-4618 Upgrade kylin docker image for kylin 3.1.0
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on a change in pull request #1303:
URL: https://github.com/apache/kylin/pull/1303#discussion_r449842363
##########
File path: docker/entrypoint.sh
##########
@@ -82,7 +79,7 @@ then
$KAFKA_HOME/bin/kafka-topics.sh --create --zookeeper localhost:2181 --replication-factor 1 --partitions 3 --topic kylin_streaming_topic
fi
-nohup $KYLIN_HOME/bin/kylin.sh org.apache.kylin.source.kafka.util.KafkaSampleProducer --topic kylin_streaming_topic --broker localhost:9092 > /dev/null 2>&1 > /tmp/kafka-sample.log &
+# nohup $KYLIN_HOME/bin/kylin.sh org.apache.kylin.source.kafka.util.KafkaSampleProducer --topic kylin_streaming_topic --broker localhost:9092 > /dev/null 2>&1 > /tmp/kafka-sample.log &
Review comment:
Is this `KafkaProduer` cause any problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls commented on pull request #1303: KYLIN-4618 Upgrade kylin docker image for kylin 3.1.0
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1303:
URL: https://github.com/apache/kylin/pull/1303#issuecomment-653366697
## Pull Request Test Coverage Report for [Build 6097](https://coveralls.io/builds/31840904)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **5** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.008%**) to **27.982%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/31840904/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/31840904/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 4 | 78.12% |
<!-- | **Total:** | **5** | | -->
| Totals | [](https://coveralls.io/builds/31840904) |
| :-- | --: |
| Change from base [Build 6065](https://coveralls.io/builds/31633725): | 0.008% |
| Covered Lines: | 26116 |
| Relevant Lines: | 93331 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on a change in pull request #1303: KYLIN-4618 Upgrade kylin docker image for kylin 3.1.0
Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1303:
URL: https://github.com/apache/kylin/pull/1303#discussion_r449943893
##########
File path: docker/entrypoint.sh
##########
@@ -82,7 +79,7 @@ then
$KAFKA_HOME/bin/kafka-topics.sh --create --zookeeper localhost:2181 --replication-factor 1 --partitions 3 --topic kylin_streaming_topic
fi
-nohup $KYLIN_HOME/bin/kylin.sh org.apache.kylin.source.kafka.util.KafkaSampleProducer --topic kylin_streaming_topic --broker localhost:9092 > /dev/null 2>&1 > /tmp/kafka-sample.log &
+# nohup $KYLIN_HOME/bin/kylin.sh org.apache.kylin.source.kafka.util.KafkaSampleProducer --topic kylin_streaming_topic --broker localhost:9092 > /dev/null 2>&1 > /tmp/kafka-sample.log &
Review comment:
This command will send data to kafka continuously, which will generate too much data. I think it can be started manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1303: KYLIN-4618 Upgrade kylin docker image for kylin 3.1.0
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1303:
URL: https://github.com/apache/kylin/pull/1303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org