You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/03/17 14:58:51 UTC

[GitHub] [trafficserver] zwoop commented on a change in pull request #7516: Adding TCP Info header support to header rewrite

zwoop commented on a change in pull request #7516:
URL: https://github.com/apache/trafficserver/pull/7516#discussion_r596098453



##########
File path: plugins/header_rewrite/parser.cc
##########
@@ -244,6 +244,14 @@ Parser::cond_is_hook(TSHttpHookID &hook) const
     hook = TS_REMAP_PSEUDO_HOOK;
     return true;
   }
+  if ("TXN_START_HOOK" == _op) {

Review comment:
       Yeh, but I'm thinking it should maybe be a warning or even an error if TXN_START_HOOK is used in a remap plugin.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org