You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by cz...@apache.org on 2018/03/29 03:31:56 UTC

svn commit: r1827955 - /felix/trunk/osgi-r7/http/base/src/main/java/org/apache/felix/http/base/internal/handler/HttpSessionWrapper.java

Author: cziegeler
Date: Thu Mar 29 03:31:56 2018
New Revision: 1827955

URL: http://svn.apache.org/viewvc?rev=1827955&view=rev
Log:
FELIX-5819 : Container session should not be invalidated

Modified:
    felix/trunk/osgi-r7/http/base/src/main/java/org/apache/felix/http/base/internal/handler/HttpSessionWrapper.java

Modified: felix/trunk/osgi-r7/http/base/src/main/java/org/apache/felix/http/base/internal/handler/HttpSessionWrapper.java
URL: http://svn.apache.org/viewvc/felix/trunk/osgi-r7/http/base/src/main/java/org/apache/felix/http/base/internal/handler/HttpSessionWrapper.java?rev=1827955&r1=1827954&r2=1827955&view=diff
==============================================================================
--- felix/trunk/osgi-r7/http/base/src/main/java/org/apache/felix/http/base/internal/handler/HttpSessionWrapper.java (original)
+++ felix/trunk/osgi-r7/http/base/src/main/java/org/apache/felix/http/base/internal/handler/HttpSessionWrapper.java Thu Mar 29 03:31:56 2018
@@ -317,6 +317,7 @@ public class HttpSessionWrapper implemen
         this.delegate.removeAttribute(ATTR_LAST_ACCESSED + this.sessionId);
         this.delegate.removeAttribute(ATTR_MAX_INACTIVE + this.sessionId);
 
+        // remove all attributes belonging to this session
         final Enumeration<String> names = this.delegate.getAttributeNames();
         while ( names.hasMoreElements() )
         {
@@ -327,12 +328,6 @@ public class HttpSessionWrapper implemen
             }
         }
 
-        // if the session is empty we can invalidate
-        if ( !this.delegate.getAttributeNames().hasMoreElements() )
-        {
-            this.delegate.invalidate();
-        }
-
         this.isInvalid = true;
     }