You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2015/07/23 00:08:32 UTC
Re: Review Request 36703: Replace Guava Joiner with String::join where
simpler
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36703/
-----------------------------------------------------------
(Updated July 22, 2015, 3:08 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
Review feedback.
Summary (updated)
-----------------
Replace Guava Joiner with String::join where simpler
Repository: aurora
Description (updated)
-------
Now that `String::join` is part of the standard library some uses of Guava's `Joiner` can be removed.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/base/JobKeys.java a5ffa5e95b301e536a84acf02817ea0c080559d0
src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 904dd72dbb9036d8c06353a953bf35b8f04cfdbc
src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 45e062d3acbd7b8565bd3773c1e994aae96378e0
src/main/java/org/apache/aurora/scheduler/http/CorsFilter.java e413ad9bdccc329777b3d0764ba8684539956679
src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 7c8f8b9b8d7deb082edc0f85a6d3da1536735545
Diff: https://reviews.apache.org/r/36703/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Kevin Sweeney
Re: Review Request 36703: Replace Guava Joiner with String::join where
simpler
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36703/#review92662
-----------------------------------------------------------
Master (8bdfb85) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 22, 2015, 10:08 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36703/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 10:08 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Now that `String::join` is part of the standard library some uses of Guava's `Joiner` can be removed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/JobKeys.java a5ffa5e95b301e536a84acf02817ea0c080559d0
> src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 904dd72dbb9036d8c06353a953bf35b8f04cfdbc
> src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 45e062d3acbd7b8565bd3773c1e994aae96378e0
> src/main/java/org/apache/aurora/scheduler/http/CorsFilter.java e413ad9bdccc329777b3d0764ba8684539956679
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 7c8f8b9b8d7deb082edc0f85a6d3da1536735545
>
> Diff: https://reviews.apache.org/r/36703/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 36703: Replace Guava Joiner with String::join where
simpler
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36703/#review92669
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On July 22, 2015, 10:08 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36703/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 10:08 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Now that `String::join` is part of the standard library some uses of Guava's `Joiner` can be removed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/JobKeys.java a5ffa5e95b301e536a84acf02817ea0c080559d0
> src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 904dd72dbb9036d8c06353a953bf35b8f04cfdbc
> src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 45e062d3acbd7b8565bd3773c1e994aae96378e0
> src/main/java/org/apache/aurora/scheduler/http/CorsFilter.java e413ad9bdccc329777b3d0764ba8684539956679
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 7c8f8b9b8d7deb082edc0f85a6d3da1536735545
>
> Diff: https://reviews.apache.org/r/36703/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>