You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by "Arghyahub (via GitHub)" <gi...@apache.org> on 2023/05/19 16:18:43 UTC

[GitHub] [apisix] Arghyahub opened a new pull request, #9516: fix: populate default log_format for logging plugins

Arghyahub opened a new pull request, #9516:
URL: https://github.com/apache/apisix/pull/9516

### Description

As requested on issue #9284 , I have inserted value to the `Default` field of `log_format`

This PR popluates the field with data `{"host": "$host", "@timestamp": "$time_iso8601", "client_ip": "$remote_addr"}`

Fixes #9284

### Checklist

- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)

<!--

Note

1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.

-->

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Arghyahub commented on pull request #9516: fix: populate default log_format for logging plugins

Posted by "Arghyahub (via GitHub)" <gi...@apache.org>.

Arghyahub commented on PR #9516:
URL: https://github.com/apache/apisix/pull/9516#issuecomment-1554948537

   Okay


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Arghyahub commented on pull request #9516: docs: populate default log_format for logging plugins

Posted by "Arghyahub (via GitHub)" <gi...@apache.org>.

Arghyahub commented on PR #9516:
URL: https://github.com/apache/apisix/pull/9516#issuecomment-1555032912

   I have updated all plugin docs that includes the field.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] monkeyDluffy6017 merged pull request #9516: docs: populate default log_format for logging plugins

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.

monkeyDluffy6017 merged PR #9516:
URL: https://github.com/apache/apisix/pull/9516


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] kayx23 commented on pull request #9516: fix: populate default log_format for logging plugins

Posted by "kayx23 (via GitHub)" <gi...@apache.org>.

kayx23 commented on PR #9516:
URL: https://github.com/apache/apisix/pull/9516#issuecomment-1554817627

   Thanks for the contribution. 
   
   Please update the PR type from `fix` to `docs`.
   
   Also, the original issue mentions a review and update to **all** plugin docs that include this field. Not just the syslog doc. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9516: docs: populate default log_format for logging plugins

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.

monkeyDluffy6017 commented on PR #9516:
URL: https://github.com/apache/apisix/pull/9516#issuecomment-1558764185

   @kayx23 please help to review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org